Staging: rtl8192e: Using kzalloc and delete memset
authorFelix Schlepper <f3sch.git@outlook.com>
Fri, 24 Jun 2022 13:54:54 +0000 (15:54 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 27 Jun 2022 11:50:03 +0000 (13:50 +0200)
By using kzalloc, we can delete a memset.  The practical difference
is that using kzalloc() will zero out the txb->fragments[] array.
The original code worked fine, but zeroing everything seems nicer.

Signed-off-by: Felix Schlepper <f3sch.git@outlook.com>
Link: https://lore.kernel.org/r/9727fe31c675f2f3052ca2fa586d137dd856ac91.1656078068.git.f3sch.git@outlook.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtllib_tx.c

index f2ef32e..1307cf5 100644 (file)
@@ -205,11 +205,10 @@ static struct rtllib_txb *rtllib_alloc_txb(int nr_frags, int txb_size,
        struct rtllib_txb *txb;
        int i;
 
-       txb = kmalloc(struct_size(txb, fragments, nr_frags), gfp_mask);
+       txb = kzalloc(struct_size(txb, fragments, nr_frags), gfp_mask);
        if (!txb)
                return NULL;
 
-       memset(txb, 0, sizeof(struct rtllib_txb));
        txb->nr_frags = nr_frags;
        txb->frag_size = cpu_to_le16(txb_size);