staging: rtl8192e: Remove u4RegValue which is always zero
authorPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Fri, 20 Jan 2023 20:18:26 +0000 (21:18 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 23 Jan 2023 18:04:38 +0000 (19:04 +0100)
As the array antenna_tx_pwr_diff is always zero, u4RegValue is always set
to zero. Replace u4RegValue to avoid CamelCase which is not accepted by
checkpatch.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/2aa104c0f7a5cede7eea289fe92390295592b0e9.1674244819.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c

index c969c40..d56c58e 100644 (file)
@@ -586,7 +586,6 @@ void rtl92e_set_tx_power(struct net_device *dev, u8 channel)
 {
        struct r8192_priv *priv = rtllib_priv(dev);
        u8      powerlevel = 0, powerlevelOFDM24G = 0;
-       u32     u4RegValue;
 
        if (priv->epromtype == EEPROM_93C46) {
                powerlevel = priv->tx_pwr_level_cck[channel - 1];
@@ -603,13 +602,8 @@ void rtl92e_set_tx_power(struct net_device *dev, u8 channel)
                        priv->antenna_tx_pwr_diff[1] = 0;
                        priv->antenna_tx_pwr_diff[0] = 0;
 
-                       u4RegValue = priv->antenna_tx_pwr_diff[2] << 8 |
-                                     priv->antenna_tx_pwr_diff[1] << 4 |
-                                     priv->antenna_tx_pwr_diff[0];
-
                        rtl92e_set_bb_reg(dev, rFPGA0_TxGainStage,
-                                         (bXBTxAGC|bXCTxAGC|bXDTxAGC),
-                                         u4RegValue);
+                                         (bXBTxAGC | bXCTxAGC | bXDTxAGC), 0);
                }
        }
        switch (priv->rf_chip) {