isohybrid, mkdiskimage: don't use sysopen(), sysread()

Don't use sysopen() and sysread() when it doesn't make sense.
Especially avoid using sysread() -- sysopen() can be used with read();
the C fdopen() is implicit.

Signed-off-by: H. Peter Anvin <hpa@zytor.com>

diff --git a/utils/isohybrid.in b/utils/isohybrid.in
index 5e3f785..1dcdf10 100644 (file)
--- a/utils/isohybrid.in
+++ b/utils/isohybrid.in
@@ -31,8 +31,7 @@ sub get_random() {
     my $rfd, $rnd;
     my $rid;
 
-    if (sysopen($rfd, '/dev/urandom', O_RDONLY) &&
-       sysread($rfd, $rnd, 4) == 4) {
+    if (open($rfd, "< /dev/urandom\0") && read($rfd, $rnd, 4) == 4) {
        $rid = unpack("V", $rnd);
     }
 

diff --git a/utils/mkdiskimage.in b/utils/mkdiskimage.in
index f66ad7c..1ce8b64 100644 (file)
--- a/utils/mkdiskimage.in
+++ b/utils/mkdiskimage.in
@@ -44,8 +44,7 @@ sub get_random() {
     my $rfd, $rnd;
     my $rid;
 
-    if (sysopen($rfd, '/dev/urandom', O_RDONLY) &&
-       sysread($rfd, $rnd, 4) == 4) {
+    if (open($rfd, "< /dev/urandom\0") && read($rfd, $rnd, 4) == 4) {
        $rid = unpack("V", $rnd);
     }