radv/rt: Don't upload the prolog twice.
authorTatsuyuki Ishi <ishitatsuyuki@gmail.com>
Thu, 16 Mar 2023 06:32:48 +0000 (15:32 +0900)
committerMarge Bot <emma+marge@anholt.net>
Thu, 16 Mar 2023 12:27:21 +0000 (12:27 +0000)
radv_shader_create already calls radv_shader_binary_upload.

Fixes: 4b92a532859 ("radv: add radv_create_rt_prolog()")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21945>

src/amd/vulkan/radv_shader.c

index 3826715..631fc79 100644 (file)
@@ -2560,10 +2560,7 @@ radv_create_rt_prolog(struct radv_device *device)
 
    prolog = radv_shader_create(device, binary, device->keep_shader_info, false, &in_args);
    if (!prolog)
-      goto fail_create;
-
-   if (!radv_shader_binary_upload(device, binary, prolog))
-      goto fail_alloc;
+      goto fail;
 
    if (options.dump_shader) {
       fprintf(stderr, "Raytracing prolog");
@@ -2572,9 +2569,7 @@ radv_create_rt_prolog(struct radv_device *device)
 
    return prolog;
 
-fail_alloc:
-   radv_shader_destroy(device, prolog);
-fail_create:
+fail:
    free(binary);
    return NULL;
 }