[Coverity] Fix the coverity issue
authorDonghyeon Jeong <dhyeon.jeong@samsung.com>
Thu, 21 Mar 2024 07:42:43 +0000 (16:42 +0900)
committerjijoong.moon <jijoong.moon@samsung.com>
Thu, 28 Mar 2024 23:44:54 +0000 (08:44 +0900)
This PR resolves the coverity issues of use of auto that causes a copy.

**Self-evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test:   [X]Passed [ ]Failed [ ]Skipped

Change-Id: Id29ed85298bd22002f81782c122041988dca22b0
Signed-off-by: Donghyeon Jeong <dhyeon.jeong@samsung.com>
nntrainer/graph/network_graph.cpp
test/unittest/unittest_nntrainer_models.cpp

index d23bb5a7d783129ff1b5418eff38e534adfc2a5b..baaed566b0c7d133283d32cc0982a5bcd198ef8d 100644 (file)
@@ -730,9 +730,9 @@ NetworkGraph::finalizeContext(const std::shared_ptr<LayerNode> &lnode,
    */
   std::vector<std::string> input_names;
   input_names.reserve(prev_inputs.size());
-  std::transform(prev_inputs.begin(), prev_inputs.end(),
-                 std::back_inserter(input_names),
-                 [](auto const &vg) -> const auto &{ return vg->getName(); });
+  std::transform(
+    prev_inputs.begin(), prev_inputs.end(), std::back_inserter(input_names),
+    [](auto const &vg) -> const auto & { return vg->getName(); });
   const std::vector<Var_Grad *> &inputs = tensor_manager->requestInputs(
     gnode, init_context.getInputDimensions(), input_names);
 
@@ -859,6 +859,7 @@ NetworkGraph::finalizeContext(const std::shared_ptr<LayerNode> &lnode,
   return outputs;
 }
 
+
 #ifdef ENABLE_TEST
 
 std::map<std::string, std::vector<unsigned int>>
@@ -1156,12 +1157,14 @@ void NetworkGraph::setInputsLabels(sharedConstTensors &inputs,
                                    sharedConstTensors &labels) {
 
   std::vector<Tensor> ins;
-  std::transform(inputs.begin(), inputs.end(), std::back_inserter(ins),
-                 [](auto const &val) -> const auto &{ return *val.get(); });
+  std::transform(
+    inputs.begin(), inputs.end(), std::back_inserter(ins),
+    [](auto const &val) -> const auto & { return *val.get(); });
 
   std::vector<Tensor> labs;
-  std::transform(labels.begin(), labels.end(), std::back_inserter(labs),
-                 [](auto const &val) -> const auto &{ return *val.get(); });
+  std::transform(
+    labels.begin(), labels.end(), std::back_inserter(labs),
+    [](auto const &val) -> const auto & { return *val.get(); });
 
   setInputsLabels(ins, labs);
 }
index de9afc39ed5f5ed3a02806637c6f524e866c9396..4f2f7eed968483db1c8bb9dc42b30f121c3d7635 100644 (file)
@@ -1047,7 +1047,7 @@ GTEST_PARAMETER_TEST(
       // this must match training (verify only forwarding output values) for 2 iterations with tolerance 1.2e-4
       // mkResNet18Tc(2, ModelTestOption::COMPARE)
     }
-), [](const testing::TestParamInfo<nntrainerModelTest::ParamType>& info){
+), [](const testing::TestParamInfo<nntrainerModelTest::ParamType>& info) -> const auto &{
  return std::get<1>(info.param);
 });
 // clang-format on