contributing: about re-sending patches
authorPekka Paalanen <pekka.paalanen@collabora.co.uk>
Tue, 3 Jul 2018 10:32:02 +0000 (13:32 +0300)
committerDerek Foreman <derek.foreman.samsung@gmail.com>
Fri, 13 Jul 2018 16:20:07 +0000 (11:20 -0500)
This is what is generally expected from people who re-send patches,
whether the patches are their own or not.

Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Reviewed-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Derek Foreman <derek.foreman.samsung@gmail.com>
CONTRIBUTING.md

index cbe02a3..9442d75 100644 (file)
@@ -43,6 +43,14 @@ responsibility for the copyright status of the code.
 
 We won't reject patches that lack S-o-b, but it is strongly recommended.
 
+When you re-send patches, revised or not, it would be very good to document the
+changes compared to the previous revision in the commit message and/or the
+cover letter. If you have already received Reviewed-by or Acked-by tags, you
+should evaluate whether they still apply and include them in the respective
+commit messages. Otherwise the tags may be lost, reviewers miss the credit they
+deserve, and the patches may cause redundant review effort.
+
+
 Tracking patches and following up
 ---------------------------------