RDMA/cm: Respect returned status of cm_init_av_by_path
authorLeon Romanovsky <leonro@mellanox.com>
Thu, 11 Oct 2018 19:36:10 +0000 (22:36 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 13 Nov 2018 19:08:32 +0000 (11:08 -0800)
[ Upstream commit e54b6a3bcd1ec972b25a164bdf495d9e7120b107 ]

Add missing check for failure of cm_init_av_by_path

Fixes: e1444b5a163e ("IB/cm: Fix automatic path migration support")
Reported-by: Slava Shwartsman <slavash@mellanox.com>
Reviewed-by: Parav Pandit <parav@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/infiniband/core/cm.c

index 6e39c27..4c53327 100644 (file)
@@ -3292,8 +3292,11 @@ static int cm_lap_handler(struct cm_work *work)
        if (ret)
                goto unlock;
 
-       cm_init_av_by_path(param->alternate_path, NULL, &cm_id_priv->alt_av,
-                          cm_id_priv);
+       ret = cm_init_av_by_path(param->alternate_path, NULL,
+                                &cm_id_priv->alt_av, cm_id_priv);
+       if (ret)
+               goto unlock;
+
        cm_id_priv->id.lap_state = IB_CM_LAP_RCVD;
        cm_id_priv->tid = lap_msg->hdr.tid;
        ret = atomic_inc_and_test(&cm_id_priv->work_count);