net: chelsio: cxgb4: add an error code check in t4_load_phy_fw
authorSu Hui <suhui@nfschina.com>
Fri, 20 Oct 2023 09:27:59 +0000 (17:27 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sun, 22 Oct 2023 10:36:30 +0000 (11:36 +0100)
t4_set_params_timeout() can return -EINVAL if failed, add check
for this.

Signed-off-by: Su Hui <suhui@nfschina.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/chelsio/cxgb4/t4_hw.c

index 8d719f8..76de553 100644 (file)
@@ -3816,6 +3816,8 @@ int t4_load_phy_fw(struct adapter *adap, int win,
                 FW_PARAMS_PARAM_Z_V(FW_PARAMS_PARAM_DEV_PHYFW_DOWNLOAD));
        ret = t4_set_params_timeout(adap, adap->mbox, adap->pf, 0, 1,
                                    &param, &val, 30000);
+       if (ret)
+               return ret;
 
        /* If we have version number support, then check to see that the new
         * firmware got loaded properly.