scsi: ufs: core: No need to update UPIU.header.flags and lun in advanced RPMB handler
authorBean Huo <beanhuo@micron.com>
Wed, 9 Aug 2023 18:18:47 +0000 (20:18 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 31 Aug 2023 01:42:30 +0000 (21:42 -0400)
For advanced RPMB requests, its UPIU package should be fully initialized in
its ufs-bsg-based application, except for task tag. in ufshcd.c, we just
copy UPIU (with CDB) request as-is.

Signed-off-by: Bean Huo <beanhuo@micron.com>
Link: https://lore.kernel.org/r/20230809181847.102123-3-beanhuo@iokpp.de
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/core/ufshcd.c

index f774169..9341751 100644 (file)
@@ -7250,9 +7250,7 @@ int ufshcd_advanced_rpmb_req_handler(struct ufs_hba *hba, struct utp_upiu_req *r
        else
                ufshcd_prepare_req_desc_hdr(lrbp, &upiu_flags, dir, 0);
 
-       /* update the task tag and LUN in the request upiu */
-       req_upiu->header.flags = upiu_flags;
-       req_upiu->header.lun = UFS_UPIU_RPMB_WLUN;
+       /* update the task tag */
        req_upiu->header.task_tag = tag;
 
        /* copy the UPIU(contains CDB) request as it is */