Fix static analysis issues 94/290294/1
authorSangyoon Jang <jeremy.jang@samsung.com>
Thu, 23 Mar 2023 00:44:58 +0000 (09:44 +0900)
committerSangyoon Jang <jeremy.jang@samsung.com>
Thu, 23 Mar 2023 00:44:58 +0000 (09:44 +0900)
Change-Id: I0f4a7b528069628ffae0154c409ab436ef39131b
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
src/manifest_parser/manifest_util.cc

index ac191549b60ea0d5067b417906acac8fb37fe021..0a30f540b6ba2a6b35908a467df1df9e4d14b1fd 100644 (file)
@@ -66,6 +66,10 @@ std::string GetNodeDir(xmlNode* node, const std::string& inherit_dir) {
     if (xmlStrEqual(prop->name, kDirAttributeKey)) {
       char* prop_value = reinterpret_cast<char *>(xmlNodeListGetString(
           node->doc, prop->children, 1));
+      if (!prop_value) {
+        LOG(ERROR) << "Failed to get value string";
+        continue;
+      }
       dir = prop_value;
       xmlFree(prop_value);
       break;
@@ -223,6 +227,10 @@ std::unique_ptr<DictionaryValue> LoadXMLNode(
   xmlAttr* prop = nullptr;
   for (prop = root->properties; prop; prop = prop->next) {
     xmlChar* value_ptr = xmlNodeListGetString(root->doc, prop->children, 1);
+    if (!value_ptr) {
+      LOG(ERROR) << "Failed to get value string";
+      continue;
+    }
     std::string prop_value(reinterpret_cast<const char*>(value_ptr));
     std::string prop_name(reinterpret_cast<const char*>(prop->name));
     xmlFree(value_ptr);