drivers: net: can: use setup_timer() helper.
authorAllen Pais <allen.lkml@gmail.com>
Thu, 21 Sep 2017 17:04:57 +0000 (22:34 +0530)
committerDavid S. Miller <davem@davemloft.net>
Thu, 21 Sep 2017 18:44:42 +0000 (11:44 -0700)
Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/can/grcan.c

index a7be12d..8570cfd 100644 (file)
@@ -1626,13 +1626,11 @@ static int grcan_setup_netdev(struct platform_device *ofdev,
        spin_lock_init(&priv->lock);
 
        if (priv->need_txbug_workaround) {
-               init_timer(&priv->rr_timer);
-               priv->rr_timer.function = grcan_running_reset;
-               priv->rr_timer.data = (unsigned long)dev;
+               setup_timer(&priv->rr_timer, grcan_running_reset,
+                           (unsigned long)dev);
 
-               init_timer(&priv->hang_timer);
-               priv->hang_timer.function = grcan_initiate_running_reset;
-               priv->hang_timer.data = (unsigned long)dev;
+               setup_timer(&priv->hang_timer, grcan_initiate_running_reset,
+                           (unsigned long)dev);
        }
 
        netif_napi_add(dev, &priv->napi, grcan_poll, GRCAN_NAPI_WEIGHT);