ath11k: fix workqueue not getting destroyed after rmmod
authorAditya Kumar Singh <quic_adisi@quicinc.com>
Mon, 10 Jan 2022 14:24:14 +0000 (16:24 +0200)
committerKalle Valo <quic_kvalo@quicinc.com>
Tue, 11 Jan 2022 14:38:32 +0000 (16:38 +0200)
Currently, ath11k_core_alloc() creates a single thread workqueue.
This workqueue is not detroyed during clean up when ath11k modules
are unloaded from the kernel and is left as it is.
If workqueue is not destroyed, it could lead to kernel
memory scarcity in a longer run. This could affect self and
other drivers workability as well.

Add destroy workqueue in ath11k_core_free().

Tested on: IPQ8074 WLAN.HK.2.4.0.1-01746-QCAHKSWPL_SILICONZ-1

Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/1640231787-17408-1-git-send-email-quic_adisi@quicinc.com
drivers/net/wireless/ath/ath11k/core.c

index 293563b..1ad77bd 100644 (file)
@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: BSD-3-Clause-Clear
 /*
  * Copyright (c) 2018-2019 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2021 Qualcomm Innovation Center, Inc. All rights reserved.
  */
 
 #include <linux/module.h>
@@ -1404,6 +1405,9 @@ EXPORT_SYMBOL(ath11k_core_deinit);
 
 void ath11k_core_free(struct ath11k_base *ab)
 {
+       flush_workqueue(ab->workqueue);
+       destroy_workqueue(ab->workqueue);
+
        kfree(ab);
 }
 EXPORT_SYMBOL(ath11k_core_free);