Updating BuildTools, CoreCLR to preview4-03828-01, preview4-27528-71, respectively...
authorTanner Gooding <tagoo@outlook.com>
Fri, 29 Mar 2019 13:32:52 +0000 (06:32 -0700)
committerGitHub <noreply@github.com>
Fri, 29 Mar 2019 13:32:52 +0000 (06:32 -0700)
* Removing FeedTasksPackageVersion from dependencies.props
* The corresponding metadata was removed in https://github.com/dotnet/coreclr/pull/22884

* Updating BuildTools, CoreCLR to preview4-03828-01, preview4-27528-71, respectively

* Adding a ! in String.Searching.cs

BuildToolsVersion.txt
ILAsmVersion.txt
dependencies.props
src/System.Private.CoreLib/shared/System/String.Searching.cs

index c452d56..2dc3810 100644 (file)
@@ -1 +1 @@
-3.0.0-preview1-03723-01
+3.0.0-preview4-03828-01
index 5967a38..abee55d 100644 (file)
@@ -1 +1 @@
-3.0.0-preview4-27427-72
+3.0.0-preview4-27528-71
index fc82a23..130926c 100644 (file)
 
   <!-- Source of truth for dependency tooling: the commit hash of the dotnet/versions master branch as of the last auto-upgrade. -->
   <PropertyGroup>
-    <CoreClrCurrentRef>9ff62111734d641ece5e5ccb873f2a463675d81b</CoreClrCurrentRef>
-    <BuildToolsCurrentRef>9ff62111734d641ece5e5ccb873f2a463675d81b</BuildToolsCurrentRef>
+    <CoreClrCurrentRef>79eb261c83005ea1c93c7861d374d1dd16a07353</CoreClrCurrentRef>
+    <BuildToolsCurrentRef>79eb261c83005ea1c93c7861d374d1dd16a07353</BuildToolsCurrentRef>
   </PropertyGroup>
 
   <!-- Tests/infrastructure dependency versions. -->
   <PropertyGroup>
-    <MicrosoftNETCoreRuntimeCoreCLRPackageVersion>3.0.0-preview4-27427-72</MicrosoftNETCoreRuntimeCoreCLRPackageVersion>
+    <MicrosoftNETCoreRuntimeCoreCLRPackageVersion>3.0.0-preview4-27528-71</MicrosoftNETCoreRuntimeCoreCLRPackageVersion>
     <XunitPackageVersion>2.4.1</XunitPackageVersion>
     <XunitPerformanceApiPackageVersion>1.0.0-beta-build0015</XunitPerformanceApiPackageVersion>
     <MicrosoftDiagnosticsTracingTraceEventPackageVersion>2.0.36</MicrosoftDiagnosticsTracingTraceEventPackageVersion>
       <Path>$(MSBuildThisFileDirectory)BuildToolsVersion.txt</Path>
       <PackageId>Microsoft.DotNet.BuildTools</PackageId>
     </UpdateStep>
-    <XmlUpdateStep Include="BuildTools">
-       <Path>$(MSBuildThisFileFullPath)</Path>
-       <ElementName>FeedTasksPackageVersion</ElementName>
-       <PackageId>$(FeedTasksPackage)</PackageId>
-    </XmlUpdateStep>
     <UpdateStep Include="ILAsm">
       <UpdaterType>File</UpdaterType>
       <Path>$(MSBuildThisFileDirectory)ILAsmVersion.txt</Path>
index 49c0654..de91b3b 100644 (file)
@@ -19,7 +19,7 @@ namespace System
             return SpanHelpers.IndexOf(
                 ref _firstChar,
                 Length,
-                ref value._firstChar,
+                ref value!._firstChar,      // TODO-NULLABLE: Compiler Bug?
                 value.Length) >= 0;
         }