staging: rtl8723bs: hal: hal_btcoex: Using comparison to true is error prone
authorHariprasad Kelam <hariprasad.kelam@gmail.com>
Wed, 26 Jun 2019 02:41:51 +0000 (08:11 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 1 Jul 2019 07:11:23 +0000 (09:11 +0200)
fix below issues reported by checkpatch

CHECK: Using comparison to true is error prone
CHECK: Using comparison to false is error prone

Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/hal/hal_btcoex.c

index 66caf340993f6474d68c57e6d0776bf244ffdf85..99e0b91c4c7f531bf610cf5f8bfce24eea4b67d6 100644 (file)
@@ -290,7 +290,7 @@ static u8 halbtcoutsrc_IsWifiBusy(struct adapter *padapter)
        if (check_fwstate(pmlmepriv, WIFI_ASOC_STATE) == true) {
                if (check_fwstate(pmlmepriv, WIFI_AP_STATE) == true)
                        return true;
-               if (true == pmlmepriv->LinkDetectInfo.bBusyTraffic)
+               if (pmlmepriv->LinkDetectInfo.bBusyTraffic)
                        return true;
        }
 
@@ -310,12 +310,12 @@ static u32 _halbtcoutsrc_GetWifiLinkStatus(struct adapter *padapter)
 
        if (check_fwstate(pmlmepriv, WIFI_ASOC_STATE) == true) {
                if (check_fwstate(pmlmepriv, WIFI_AP_STATE) == true) {
-                       if (true == bp2p)
+                       if (bp2p)
                                portConnectedStatus |= WIFI_P2P_GO_CONNECTED;
                        else
                                portConnectedStatus |= WIFI_AP_CONNECTED;
                } else {
-                       if (true == bp2p)
+                       if (bp2p)
                                portConnectedStatus |= WIFI_P2P_GC_CONNECTED;
                        else
                                portConnectedStatus |= WIFI_STA_CONNECTED;
@@ -372,7 +372,7 @@ static u8 halbtcoutsrc_GetWifiScanAPNum(struct adapter *padapter)
 
        pmlmeext = &padapter->mlmeextpriv;
 
-       if (GLBtcWiFiInScanState == false) {
+       if (!GLBtcWiFiInScanState) {
                if (pmlmeext->sitesurvey_res.bss_cnt > 0xFF)
                        scan_AP_num = 0xFF;
                else
@@ -1444,7 +1444,7 @@ void hal_btcoex_IQKNotify(struct adapter *padapter, u8 state)
 
 void hal_btcoex_BtInfoNotify(struct adapter *padapter, u8 length, u8 *tmpBuf)
 {
-       if (GLBtcWiFiInIQKState == true)
+       if (GLBtcWiFiInIQKState)
                return;
 
        EXhalbtcoutsrc_BtInfoNotify(&GLBtCoexist, tmpBuf, length);