Navigate forward button is disabled.
authorKarol Furmaniak <k.furmaniak@samsung.com>
Tue, 3 Feb 2015 13:56:38 +0000 (14:56 +0100)
committerYoungsoo Choi <kenshin.choi@samsung.com>
Tue, 10 Jul 2018 06:57:09 +0000 (06:57 +0000)
[Problem]: After navigate with "back" button forward button
is still disabled.

[Solution]: Invoking BackForwardListChangedCallback depends on
back/forward list count difference.
Unnecessary condition was removed.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10900
Reviewed by: Jaesik Chang, Piotr Grad, arno renevier

Change-Id: I080925a6ee8b42345fd5bd8df8d39d45ec1a489f
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
tizen_src/impl/web_contents_delegate_efl.cc
tizen_src/impl/web_contents_delegate_efl.h

index 88b8ea8..cb31224 100644 (file)
@@ -72,7 +72,6 @@ WebContentsDelegateEfl::WebContentsDelegateEfl(EWebView* view)
     , web_contents_(view->web_contents())
     , document_created_(false)
     , dialog_manager_(NULL)
-    , forward_backward_list_count_(0)
     , WebContentsObserver(&view->web_contents())
     , weak_ptr_factory_(this) {
 #ifdef TIZEN_AUTOFILL_SUPPORT
@@ -547,11 +546,7 @@ void WebContentsDelegateEfl::OnPrintedMetafileReceived(const DidPrintPagesParams
 }
 
 void WebContentsDelegateEfl::NavigationEntryCommitted(const LoadCommittedDetails& load_details) {
-  int forward_backward_list_count = web_contents_.GetController().GetEntryCount();
-  if (forward_backward_list_count != forward_backward_list_count_) {
-    web_view_->InvokeBackForwardListChangedCallback();
-    forward_backward_list_count_ = forward_backward_list_count;
-  }
+  web_view_->InvokeBackForwardListChangedCallback();
 }
 
 void WebContentsDelegateEfl::RenderProcessGone(base::TerminationStatus status) {
index 77d1b2f..c8c8919 100644 (file)
@@ -202,7 +202,6 @@ class WebContentsDelegateEfl
   scoped_ptr<ContentSecurityPolicy> pending_content_security_policy_;
   bool document_created_;
   JavaScriptDialogManagerEfl* dialog_manager_;
-  int forward_backward_list_count_;
   scoped_ptr<FaviconDownloader> favicon_downloader_;
   base::WeakPtrFactory<WebContentsDelegateEfl> weak_ptr_factory_;
   scoped_ptr<_Ewk_Certificate_Policy_Decision> certificate_policy_decision_;