NFSD: fix leaked reference count of nfsd4_ssc_umount_item

[ Upstream commit 34e8f9ec4c9ac235f917747b23a200a5e0ec857b ]

The reference count of nfsd4_ssc_umount_item is not decremented
on error conditions. This prevents the laundromat from unmounting
the vfsmount of the source file.

This patch decrements the reference count of nfsd4_ssc_umount_item
on error.

Fixes: f4e44b393389 ("NFSD: delay unmount source's export after inter-server copy completed.")
Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
index 92b63e5..32652b5 100644 (file)
--- a/fs/nfsd/nfs4proc.c
+++ b/fs/nfsd/nfs4proc.c
@@ -1827,13 +1827,17 @@ nfsd4_copy(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
 out:
        return status;
 out_err:
+       if (nfsd4_ssc_is_inter(copy)) {
+               /*
+                * Source's vfsmount of inter-copy will be unmounted
+                * by the laundromat. Use copy instead of async_copy
+                * since async_copy->ss_nsui might not be set yet.
+                */
+               refcount_dec(&copy->ss_nsui->nsui_refcnt);
+       }
        if (async_copy)
                cleanup_async_copy(async_copy);
        status = nfserrno(-ENOMEM);
-       /*
-        * source's vfsmount of inter-copy will be unmounted
-        * by the laundromat
-        */
        goto out;
 }