mailbox: arm_mhu: Remove redundant error printing in mhu_probe()
authorZhen Lei <thunder.leizhen@huawei.com>
Tue, 11 May 2021 09:45:21 +0000 (17:45 +0800)
committerJassi Brar <jaswinder.singh@linaro.org>
Sat, 26 Jun 2021 16:37:48 +0000 (11:37 -0500)
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.

Therefore, remove the error printing here to simplify code and reduce the
binary size.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
drivers/mailbox/arm_mhu.c

index b7fbf27..22243ca 100644 (file)
@@ -122,10 +122,8 @@ static int mhu_probe(struct amba_device *adev, const struct amba_id *id)
                return -ENOMEM;
 
        mhu->base = devm_ioremap_resource(dev, &adev->res);
-       if (IS_ERR(mhu->base)) {
-               dev_err(dev, "ioremap failed\n");
+       if (IS_ERR(mhu->base))
                return PTR_ERR(mhu->base);
-       }
 
        for (i = 0; i < MHU_CHANS; i++) {
                mhu->chan[i].con_priv = &mhu->mlink[i];