tty: hvc: Return proper error code from console ->setup() hook
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 18 Jun 2020 16:47:49 +0000 (19:47 +0300)
committerPetr Mladek <pmladek@suse.com>
Thu, 25 Jun 2020 12:23:06 +0000 (14:23 +0200)
For unifying console ->setup() handling, which is poorly documented,
return error code, rather than non-zero arbitrary number.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20200618164751.56828-5-andriy.shevchenko@linux.intel.com
drivers/tty/hvc/hvsi.c

index 66f95f7..e8c58f9 100644 (file)
@@ -1128,7 +1128,7 @@ static int __init hvsi_console_setup(struct console *console, char *options)
        int ret;
 
        if (console->index < 0 || console->index >= hvsi_count)
-               return -1;
+               return -EINVAL;
        hp = &hvsi_ports[console->index];
 
        /* give the FSP a chance to change the baud rate when we re-open */