Fix prevent issue

[Issue#] N/A
[Bug] remove function is called without checking result.
[Cause] N/A
[Solution] check addded
[Verification] Verification steps
1. Install widget
2. Manipulate database to add non-existing locations.
3. During updating(or -if installation) or uninstalling this files should be listed as external files to be removed but not existing(warning in logs)

Change-Id: I6f4652e19b36354e39d3e339897d3cc374ce6641

diff --git a/src/jobs/widget_install/task_database.cpp b/src/jobs/widget_install/task_database.cpp
index de38c5f..ea2cd3c 100644 (file)
--- a/src/jobs/widget_install/task_database.cpp
+++ b/src/jobs/widget_install/task_database.cpp
@@ -190,7 +190,10 @@ void TaskDatabase::StepRemoveExternalFiles()
         if(WrtUtilFileExists(*file))
         {
             LogDebug("  -> " << *file);
-            remove(file->c_str());
+            if (-1 == TEMP_FAILURE_RETRY(remove(file->c_str()))) {
+                ThrowMsg(Exceptions::RemovingFileFailure,
+                         "Failed to remove external file");
+            }
         }
         else if(WrtUtilDirExists(*file))
         {

diff --git a/src/jobs/widget_install/widget_install_errors.h b/src/jobs/widget_install/widget_install_errors.h
index b3bf040..32ef9b0 100644 (file)
--- a/src/jobs/widget_install/widget_install_errors.h
+++ b/src/jobs/widget_install/widget_install_errors.h
@@ -82,6 +82,7 @@ DECLARE_JOB_EXCEPTION(Base, AlreadyInstalled, ErrorAlreadyInstalled)
 DECLARE_JOB_EXCEPTION(Base, UnknownError, ErrorUnknown)
 DECLARE_JOB_EXCEPTION(Base, DatabaseFailure, ErrorDatabaseFailure)
 DECLARE_JOB_EXCEPTION(Base, RemovingFolderFailure, ErrorRemovingFolderFailure)
+DECLARE_JOB_EXCEPTION(Base, RemovingFileFailure, ErrorRemovingFolderFailure)
 DECLARE_JOB_EXCEPTION(Base, CreateVconfFailure, ErrorCreateVconfFailure)
 
 DECLARE_JOB_EXCEPTION(Base, CopyIconFailed, ErrorUnknown)