bpf: Remove insn_buf[] declaration in inner block
authorJianlin Lv <Jianlin.Lv@arm.com>
Thu, 18 Mar 2021 02:48:51 +0000 (10:48 +0800)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 19 Mar 2021 22:06:53 +0000 (23:06 +0100)
Two insn_buf[16] variables are declared in the function which acts on
function scope and block scope respectively. The statement in the inner
block is redundant, so remove it.

Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20210318024851.49693-1-Jianlin.Lv@arm.com
kernel/bpf/verifier.c

index f9096b0..e26c517 100644 (file)
@@ -11899,7 +11899,6 @@ static int do_misc_fixups(struct bpf_verifier_env *env)
                    insn->code == (BPF_ALU64 | BPF_SUB | BPF_X)) {
                        const u8 code_add = BPF_ALU64 | BPF_ADD | BPF_X;
                        const u8 code_sub = BPF_ALU64 | BPF_SUB | BPF_X;
-                       struct bpf_insn insn_buf[16];
                        struct bpf_insn *patch = &insn_buf[0];
                        bool issrc, isneg;
                        u32 off_reg;