signal/all/do_sigaltstack remove __get_user value check
authorRiku Voipio <riku.voipio@linaro.org>
Wed, 23 Apr 2014 08:26:34 +0000 (11:26 +0300)
committerRiku Voipio <riku.voipio@linaro.org>
Tue, 17 Jun 2014 05:52:07 +0000 (08:52 +0300)
Access is already checked in the lock_user_struct
call before.

Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
linux-user/signal.c

index 2a1c681..f55076d 100644 (file)
@@ -619,11 +619,12 @@ abi_long do_sigaltstack(abi_ulong uss_addr, abi_ulong uoss_addr, abi_ulong sp)
         struct target_sigaltstack ss;
 
        ret = -TARGET_EFAULT;
-        if (!lock_user_struct(VERIFY_READ, uss, uss_addr, 1)
-           || __get_user(ss.ss_sp, &uss->ss_sp)
-           || __get_user(ss.ss_size, &uss->ss_size)
-           || __get_user(ss.ss_flags, &uss->ss_flags))
+        if (!lock_user_struct(VERIFY_READ, uss, uss_addr, 1)) {
             goto out;
+        }
+        __get_user(ss.ss_sp, &uss->ss_sp);
+        __get_user(ss.ss_size, &uss->ss_size);
+        __get_user(ss.ss_flags, &uss->ss_flags);
         unlock_user_struct(uss, uss_addr, 0);
 
        ret = -TARGET_EPERM;