bpf: fix BTF verification of enums
authorAlexei Starovoitov <ast@kernel.org>
Tue, 17 Sep 2019 17:45:37 +0000 (10:45 -0700)
committerDaniel Borkmann <daniel@iogearbox.net>
Thu, 19 Sep 2019 12:22:44 +0000 (14:22 +0200)
vmlinux BTF has enums that are 8 byte and 1 byte in size.
2 byte enum is a valid construct as well.
Fix BTF enum verification to accept those sizes.

Fixes: 69b693f0aefa ("bpf: btf: Introduce BPF Type Format (BTF)")
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
kernel/bpf/btf.c

index adb3adc..722d38e 100644 (file)
@@ -2377,9 +2377,8 @@ static s32 btf_enum_check_meta(struct btf_verifier_env *env,
                return -EINVAL;
        }
 
-       if (t->size != sizeof(int)) {
-               btf_verifier_log_type(env, t, "Expected size:%zu",
-                                     sizeof(int));
+       if (t->size > 8 || !is_power_of_2(t->size)) {
+               btf_verifier_log_type(env, t, "Unexpected size");
                return -EINVAL;
        }