qcow2: Remove bogus unlock of s->lock
authorKevin Wolf <kwolf@redhat.com>
Tue, 26 Mar 2013 16:49:55 +0000 (17:49 +0100)
committerStefan Hajnoczi <stefanha@redhat.com>
Thu, 28 Mar 2013 10:52:42 +0000 (11:52 +0100)
The unlock wakes up the next coroutine, but the currently running
coroutine will lock it again before it yields, so this doesn't make a
lot of sense.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
block/qcow2.c

index 8ea696a1aaf3fc0bac8b898f9b0611fa50069f5b..3f7edf56525797106ce8901cde0bb3a0746db0dd 100644 (file)
@@ -869,9 +869,7 @@ static coroutine_fn int qcow2_co_writev(BlockDriverState *bs,
                 QLIST_REMOVE(l2meta, next_in_flight);
             }
 
-            qemu_co_mutex_unlock(&s->lock);
             qemu_co_queue_restart_all(&l2meta->dependent_requests);
-            qemu_co_mutex_lock(&s->lock);
 
             g_free(l2meta);
             l2meta = NULL;