arm64: dts: qcom: sc7280: Fix EUD dt node syntax
authorBhupesh Sharma <bhupesh.sharma@linaro.org>
Tue, 2 May 2023 09:39:58 +0000 (15:09 +0530)
committerBjorn Andersson <andersson@kernel.org>
Thu, 25 May 2023 02:32:26 +0000 (19:32 -0700)
As noted by Konrad while reviewing [1], fix the EUD and DWC3
node syntax in sc7280 dtsi file.

While at it also fix the errors reported by '$ make dtbs_check'
for the EUD node:

 arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb: eud@88e0000: ports:
    'oneOf' conditional failed, one must be fixed:
'port' is a required property
'#address-cells' is a required property
'#size-cells' is a required property
  From schema: Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml

[1]. https://lore.kernel.org/linux-arm-msm/20221231131945.3286639-1-bhupesh.sharma@linaro.org

Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20230502093959.1258889-2-bhupesh.sharma@linaro.org
arch/arm64/boot/dts/qcom/sc7280.dtsi

index 31728f4..e441b1d 100644 (file)
                };
        };
 
+       eud_typec: connector {
+               compatible = "usb-c-connector";
+
+               ports {
+                       port@0 {
+                               con_eud: endpoint {
+                                       remote-endpoint = <&eud_con>;
+                               };
+                       };
+               };
+       };
+
        memory@80000000 {
                device_type = "memory";
                /* We expect the bootloader to fill in the size */
                                phy-names = "usb2-phy";
                                maximum-speed = "high-speed";
                                usb-role-switch;
+
                                port {
                                        usb2_role_switch: endpoint {
                                                remote-endpoint = <&eud_ep>;
                };
 
                eud: eud@88e0000 {
-                       compatible = "qcom,sc7280-eud","qcom,eud";
-                       reg = <0 0x088e0000 0 0x2000>,
-                             <0 0x088e2000 0 0x1000>;
+                       compatible = "qcom,sc7280-eud", "qcom,eud";
+                       reg = <0 0x88e0000 0 0x2000>,
+                             <0 0x88e2000 0 0x1000>;
                        interrupts-extended = <&pdc 11 IRQ_TYPE_LEVEL_HIGH>;
+
                        ports {
                                #address-cells = <1>;
                                #size-cells = <0>;
                                                remote-endpoint = <&usb2_role_switch>;
                                        };
                                };
+
                                port@1 {
                                        reg = <1>;
                                        eud_con: endpoint {
                        };
                };
 
-               eud_typec: connector {
-                       compatible = "usb-c-connector";
-                       ports {
-                               #address-cells = <1>;
-                               #size-cells = <0>;
-
-                               port@0 {
-                                       reg = <0>;
-                                       con_eud: endpoint {
-                                               remote-endpoint = <&eud_con>;
-                                       };
-                               };
-                       };
-               };
-
                nsp_noc: interconnect@a0c0000 {
                        reg = <0 0x0a0c0000 0 0x10000>;
                        compatible = "qcom,sc7280-nsp-noc";