Bluetooth: btrtl: Ignore error return for hci_devcd_register()
authorMax Chou <max.chou@realtek.com>
Fri, 6 Oct 2023 02:47:07 +0000 (10:47 +0800)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Sat, 14 Oct 2023 03:03:04 +0000 (20:03 -0700)
If CONFIG_DEV_COREDUMP was not set, it would return -EOPNOTSUPP for
hci_devcd_register().
In this commit, ignore error return for hci_devcd_register().
Otherwise Bluetooth initialization will be failed.

Fixes: 044014ce85a1 ("Bluetooth: btrtl: Add Realtek devcoredump support")
Cc: stable@vger.kernel.org
Reported-by: Kirill A. Shutemov <kirill@shutemov.name>
Closes: https://lore.kernel.org/all/ZRyqIn0_qqEFBPdy@debian.me/T/
Signed-off-by: Max Chou <max.chou@realtek.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
drivers/bluetooth/btrtl.c

index 84c2c2e..277d039 100644 (file)
@@ -962,13 +962,10 @@ static void btrtl_dmp_hdr(struct hci_dev *hdev, struct sk_buff *skb)
        skb_put_data(skb, buf, strlen(buf));
 }
 
-static int btrtl_register_devcoredump_support(struct hci_dev *hdev)
+static void btrtl_register_devcoredump_support(struct hci_dev *hdev)
 {
-       int err;
+       hci_devcd_register(hdev, btrtl_coredump, btrtl_dmp_hdr, NULL);
 
-       err = hci_devcd_register(hdev, btrtl_coredump, btrtl_dmp_hdr, NULL);
-
-       return err;
 }
 
 void btrtl_set_driver_name(struct hci_dev *hdev, const char *driver_name)
@@ -1255,8 +1252,7 @@ int btrtl_download_firmware(struct hci_dev *hdev,
        }
 
 done:
-       if (!err)
-               err = btrtl_register_devcoredump_support(hdev);
+       btrtl_register_devcoredump_support(hdev);
 
        return err;
 }