Return NULL from rpmtsProblems() if no problems exist

- Avoids callers having to separately test for number of problems
  and freeing when no problems exist

diff --git a/lib/rpmts.c b/lib/rpmts.c
index 30cf2ab..2633ff7 100644 (file)
--- a/lib/rpmts.c
+++ b/lib/rpmts.c
@@ -494,6 +494,12 @@ rpmps rpmtsProblems(rpmts ts)
        rpmpsFree(teprobs);
     }
     pi = rpmtsiFree(pi);
+
+    /* Return NULL on no problems instead of an empty set */
+    if (rpmpsNumProblems(ps) == 0) {
+       ps = rpmpsFree(ps);
+    }
+
     return ps;
 }
 

diff --git a/lib/rpmts.h b/lib/rpmts.h
index 4bae9e1..04fc9d1 100644 (file)
--- a/lib/rpmts.h
+++ b/lib/rpmts.h
@@ -316,7 +316,7 @@ int rpmtsSetSolveCallback(rpmts ts,
 /** \ingroup rpmts
  * Return current transaction set problems.
  * @param ts           transaction set
- * @return             current problem set (or NULL)
+ * @return             current problem set (or NULL if no problems)
  */
 rpmps rpmtsProblems(rpmts ts);