ALSA: usb: Delete an error message for a failed memory allocation in two functions

Omit an extra message for a memory allocation failure in these functions.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index d7b0b0a..9db40d5 100644 (file)
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -146,10 +146,9 @@ static int create_fixed_stream_quirk(struct snd_usb_audio *chip,
        unsigned *rate_table = NULL;
 
        fp = kmemdup(quirk->data, sizeof(*fp), GFP_KERNEL);
-       if (!fp) {
-               usb_audio_err(chip, "cannot memdup\n");
+       if (!fp)
                return -ENOMEM;
-       }
+
        INIT_LIST_HEAD(&fp->list);
        if (fp->nr_rates > MAX_NR_RATES) {
                kfree(fp);

diff --git a/sound/usb/stream.c b/sound/usb/stream.c
index 8e9548b..d1776e5 100644 (file)
--- a/sound/usb/stream.c
+++ b/sound/usb/stream.c
@@ -658,10 +658,8 @@ int snd_usb_parse_audio_interface(struct snd_usb_audio *chip, int iface_no)
                        continue;
 
                fp = kzalloc(sizeof(*fp), GFP_KERNEL);
-               if (! fp) {
-                       dev_err(&dev->dev, "cannot malloc\n");
+               if (!fp)
                        return -ENOMEM;
-               }
 
                fp->iface = iface_no;
                fp->altsetting = altno;