regulator: scmi: Fix refcount leak in scmi_regulator_probe
authorMiaoqian Lin <linmq006@gmail.com>
Mon, 16 May 2022 07:44:33 +0000 (11:44 +0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jun 2022 08:23:00 +0000 (10:23 +0200)
[ Upstream commit 68d6c8476fd4f448e70e0ab31ff972838ac41dae ]

of_find_node_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
Add missing of_node_put() to avoid refcount leak.

Fixes: 0fbeae70ee7c ("regulator: add SCMI driver")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220516074433.32433-1-linmq006@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/regulator/scmi-regulator.c

index 1f02f60..41ae7ac 100644 (file)
@@ -352,7 +352,7 @@ static int scmi_regulator_probe(struct scmi_device *sdev)
                        return ret;
                }
        }
-
+       of_node_put(np);
        /*
         * Register a regulator for each valid regulator-DT-entry that we
         * can successfully reach via SCMI and has a valid associated voltage