Remove compilation warnings.

[Issue#]    N/A
[Problem]   Where were so many warnings that compilation output was not readable.
[Feature]   N/A
[Cause]     N/A
[Solution]  Unsued values and params were removed from the code.

[Verification] Build.

Change-Id: I771442f2c2aefeedfd1d64d420f2861081fa7ad8

diff --git a/tests/libprivilege-control-tests/test_cases.cpp b/tests/libprivilege-control-tests/test_cases.cpp
index 7982568c002ec9399c42ba591248c242f311aae7..8ff3dd9e29e365415326be66f29c27e6630f02cd 100644 (file)
--- a/tests/libprivilege-control-tests/test_cases.cpp
+++ b/tests/libprivilege-control-tests/test_cases.cpp
@@ -848,7 +848,6 @@ RUNNER_TEST(privilege_control04_add_permissions)
 RUNNER_CHILD_TEST(privilege_control06_revoke_permissions)
 {
     int result;
-    int fd;
 
     // Revoke permissions
     result = perm_app_revoke_permissions(APP_ID);

diff --git a/tests/libsmack-tests/test_cases.cpp b/tests/libsmack-tests/test_cases.cpp
index 1a752665a848bfd11e48367f71d5ee7a650ae0ed..081697d3559061788012691ef748cc39ef6b3cbd 100644 (file)
--- a/tests/libsmack-tests/test_cases.cpp
+++ b/tests/libsmack-tests/test_cases.cpp
@@ -147,7 +147,7 @@ bool checkNoAccesses(const char *subject, const char *object)
     return true;
 }
 
-int removeAccessesAll()
+void removeAccessesAll()
 {
     struct smack_accesses *rules = NULL;
     int result = smack_accesses_new(&rules);
@@ -613,7 +613,7 @@ RUNNER_TEST(smack02_aplying_rules_into_kernel)
 }
 
 //pairs of rules for test with mixed cases, different length and mixed order
-char *rules_tab[] = {
+const char *rules_tab[] = {
     "reader1",  "-",                "-----",
     "reader2",  "--------",         "-----",
     "reader3",  "RwXaT",            "rwxat",
@@ -728,7 +728,7 @@ RUNNER_TEST(smack05_self_label)
     const int B_SIZE = 8;
     char buff[B_SIZE];
 
-    char *def_rule = "_";
+    const char *def_rule = "_";
 
     //int smack_new_label_from_self(char **label);
     result = smack_new_label_from_self(&label);
@@ -780,7 +780,7 @@ RUNNER_TEST(smack05_self_label)
 //}
 
 //bellow function is from libsmack.c witch changed name
-char *xattr(enum smack_label_type type)
+const char *xattr(enum smack_label_type type)
 {
     switch (type) {
         case SMACK_LABEL_ACCESS:
@@ -836,7 +836,7 @@ RUNNER_TEST(smack06_get_set_label)
     const int B_SIZE = 8;
     char buff[B_SIZE];
 
-    char *file_path = "/etc/smack/test_smack_rules";
+    const char *file_path = "/etc/smack/test_smack_rules";
 
 
     //preparing environment by restoring default "_" label
@@ -903,7 +903,7 @@ RUNNER_TEST(smack07_l_get_set_label)
     const int B_SIZE = 8;
     char buff[B_SIZE];
 
-    char *file_path = "/etc/smack/test_smack_rules_lnk";
+    const char *file_path = "/etc/smack/test_smack_rules_lnk";
 
 
     //preparing environment by restoring default "_" label
@@ -986,7 +986,7 @@ RUNNER_TEST(smack08_f_get_set_label)
     char buff[B_SIZE];
 
     int fd;
-    char *file_path = "/etc/smack/test_smack_rules";
+    const char *file_path = "/etc/smack/test_smack_rules";
 
     fd = open(file_path, O_RDWR, 0644);             //reference preinstalled rules
     RUNNER_ASSERT_MSG(fd >= 0, "Unable to open /etc/smack/test_smack_rules");
@@ -1370,7 +1370,7 @@ static void smack_set_another_label_for_self(void)
     char *smack_label;
 
     number++;
-    result = asprintf(&smack_label, "s%ld", number);
+    result = asprintf(&smack_label, "s%d", number);
     RUNNER_ASSERT_MSG(result > 0, "asprintf failed");
     result = smack_set_label_for_self(smack_label);
     RUNNER_ASSERT_MSG(result == 0, "smack_set_label_for_self(" << smack_label << ") failed");
@@ -1390,7 +1390,7 @@ static void smack_unix_sock_server(int sock)
     result = smack_new_label_from_self(&smack_label);
     RUNNER_ASSERT_MSG(result == 0, "smack_new_label_from_self() failed");
     result = write(fd, smack_label, strlen(smack_label));
-    RUNNER_ASSERT_MSG(result == strlen(smack_label), "write() failed");
+    RUNNER_ASSERT_MSG(result == (int)strlen(smack_label), "write() failed");
     close(fd);
     free(smack_label);
 }

diff --git a/tests/security-server-tests/security_server_clean_env.cpp b/tests/security-server-tests/security_server_clean_env.cpp
index bff1096fba15bb406a769c10f8324e8ef7b2a29c..f2b6ac147e05afc933a794f53e4b8c310417579d 100644 (file)
--- a/tests/security-server-tests/security_server_clean_env.cpp
+++ b/tests/security-server-tests/security_server_clean_env.cpp
@@ -35,7 +35,7 @@
 int restart_security_server()
 {
     int ret = -1;
-    char *dbus_client_name = "tests.dbus.client";
+    const char *dbus_client_name = "tests.dbus.client";
 
     DBusMessage* msg = NULL;
     DBusMessageIter args, iter;
@@ -82,7 +82,7 @@ int restart_security_server()
      * the call will start the unit and its dependencies,
      * but will fail if this would change an already queued job.
      */
-    char *dbus_systemd_srv_unit_mode = "fail";
+    const char *dbus_systemd_srv_unit_mode = "fail";
 
     // append arguments, mode = "fail" for "Restart" method
     dbus_message_iter_init_append(msg, &args);

diff --git a/tests/security-server-tests/security_server_measurer_API_speed.cpp b/tests/security-server-tests/security_server_measurer_API_speed.cpp
index b4299cddef1d3fb71829b73bb62f2e982fca3732..1244ecbc0a3d9ca88da67369ab1300e8d8e4e412 100644 (file)
--- a/tests/security-server-tests/security_server_measurer_API_speed.cpp
+++ b/tests/security-server-tests/security_server_measurer_API_speed.cpp
@@ -115,7 +115,7 @@ int my_pipe_read(int fd, void *buf, size_t count) {
     ssize_t rest = count;
     ssize_t s;
     while (rest > 0) {
-        RUNNER_ASSERT_MSG(0 < (s = TEMP_FAILURE_RETRY(read(fd, buf + readf, rest))), "Error in read from pipe");
+        RUNNER_ASSERT_MSG(0 < (s = TEMP_FAILURE_RETRY(read(fd, ((char*)buf) + readf, rest))), "Error in read from pipe");
         rest -= s;
         readf += s;
     }
@@ -133,7 +133,7 @@ int my_pipe_write(int fd, void *buf, size_t count) {
     ssize_t rest = count;
     ssize_t s;
     while (rest > 0) {
-        RUNNER_ASSERT_MSG(0 <= (s = TEMP_FAILURE_RETRY(write(fd, buf + writef, rest))), "Error in write to pipe");
+        RUNNER_ASSERT_MSG(0 <= (s = TEMP_FAILURE_RETRY(write(fd, ((char*)buf) + writef, rest))), "Error in write to pipe");
         rest -= s;
         writef += s;
     }

diff --git a/tests/security-server-tests/security_server_tests_dbus.cpp b/tests/security-server-tests/security_server_tests_dbus.cpp
index bc4c6c031abeec4aac7d5fcfd28f93b754018c21..83c1b8bef2067b029ed5d503d1008330dcadb918 100644 (file)
--- a/tests/security-server-tests/security_server_tests_dbus.cpp
+++ b/tests/security-server-tests/security_server_tests_dbus.cpp
@@ -38,12 +38,9 @@ RUNNER_TEST(tc01_smack_context_from_DBus)
     DBusConnection* conn = NULL;
     DBusError err;
     DBusPendingCall *pending = NULL;
-    dbus_bool_t stat;
-    dbus_uint32_t level;
-    char *dbus_server_name = DBUS_SERVER_NAME;
+    const char *dbus_server_name = DBUS_SERVER_NAME;
     char *smack_context = NULL;
     int status;
-    int result = -1;
 
     pid_t pid = fork();
     RUNNER_ASSERT_MSG(-1 != pid, "fork() failed");

diff --git a/tests/security-server-tests/security_server_tests_password.cpp b/tests/security-server-tests/security_server_tests_password.cpp
index 73857815918b9c31d9ecdfcfc0cab616a8ea35b0..8bb97a11a60dca6d8864aced1113abc8f63aa7a2 100644 (file)
--- a/tests/security-server-tests/security_server_tests_password.cpp
+++ b/tests/security-server-tests/security_server_tests_password.cpp
@@ -43,13 +43,10 @@
  * Function should be run at the begining of every test, so every test is independent of each other.
  */
 void reset_security_server(){
-    int ret;
-    unsigned int attempt, max_attempt, expire_sec;
     system("if [ -d /opt/data/security-server ]; then \n rm -rf /opt/data/security-server/*; \n fi");
     sync();
     restart_security_server();
     sleep(1);
-
 }
 
 
@@ -520,8 +517,7 @@ RUNNER_TEST(tc23_security_server_set_pwd_correct_current)
 RUNNER_TEST(tc24_security_server_attempt_exceeding)
 {
     int ret;
-    int i;
-    unsigned int attempt, max_attempt, expire_sec;
+    unsigned int i, attempt, max_attempt, expire_sec;
 
     // Prepare environment
     reset_security_server();
@@ -555,8 +551,7 @@ RUNNER_TEST(tc24_security_server_attempt_exceeding)
 RUNNER_TEST(tc25_security_server_attempt_exceeding)
 {
     int ret;
-    int i;
-    unsigned int attempt, max_attempt, expire_sec;
+    unsigned int i, attempt, max_attempt, expire_sec;
 
     // Prepare environment
     reset_security_server();

diff --git a/tests/security-server-tests/security_server_tests_pid_reuser.cpp b/tests/security-server-tests/security_server_tests_pid_reuser.cpp
index d1d316dfb9ce612000299712848d50fd1c589aef..333249984684fe6b5ff9086b4d137ba612f2c222 100644 (file)
--- a/tests/security-server-tests/security_server_tests_pid_reuser.cpp
+++ b/tests/security-server-tests/security_server_tests_pid_reuser.cpp
@@ -38,19 +38,19 @@ int cookie_size;
  * This test program must be executed as root process
  */
 
-void convert_prev_cookie(const char *cmdline, const char *prev, unsigned char *now)
+void convert_prev_cookie(const char * /*cmdline*/, const char *prev, unsigned char *now)
 {
     int i, cnt;
     char tmphexnum[3] = {0};
     cnt = security_server_get_cookie_size();
     cnt = cnt * 2;
-    if (strlen(prev) != cnt)
+    if ((int)strlen(prev) != cnt)
     {
         printf("%s\n", "Cookie length is wrong");
         exit(1);
     }
 
-    for (i = 0, cnt = 0; i < strlen(prev); i = i + 2)
+    for (i = 0, cnt = 0; i < (int)strlen(prev); i = i + 2)
     {
         strncpy(tmphexnum, prev + i, 2);
         tmphexnum[2] = 0;
@@ -117,8 +117,7 @@ int main(int argc, char *argv[])
 {
     /* FIXME: proper parameters needed (these below are fake)
      *        or better idea for this test case...*/
-    char *argvv[] = {argv[0], "12345", "5000", "abcdefabcdefabcdefabcdefabcdefabcdefabcd"};
-    int argcc = 4;
+    const char *argvv[] = {argv[0], "12345", "5000", "abcdefabcdefabcdefabcdefabcdefabcdefabcd"};
 
     target_uid = getuid();
     if (target_uid != 0)

diff --git a/tests/security-server-tests/security_server_tests_server.cpp b/tests/security-server-tests/security_server_tests_server.cpp
index 92f2fc9eba52ca9289e9cd52e1dbaea5246705f9..ed1bf1a5220cb356cd3d6ed650da467b9a2a2608 100644 (file)
--- a/tests/security-server-tests/security_server_tests_server.cpp
+++ b/tests/security-server-tests/security_server_tests_server.cpp
@@ -294,8 +294,7 @@ int connect_to_server(int *fd)
 
 int fake_get_gid(const char *object)
 {
-    int sockfd = -1, retval, gid;
-    response_header hdr;
+    int sockfd = -1, retval;
 
     retval = connect_to_server(&sockfd);
     if (retval != 0)
@@ -322,7 +321,7 @@ error:
     return 0;
 }
 
-static int nftw_rmdir_contents(const char *fpath, const struct stat *sb,
+static int nftw_rmdir_contents(const char *fpath, const struct stat * /*sb*/,
                                int tflag, struct FTW *ftwbuf)
 {
     if (tflag == FTW_F) {
@@ -335,7 +334,7 @@ static int nftw_rmdir_contents(const char *fpath, const struct stat *sb,
     return 0;
 }
 
-int clear_password(char **error)
+int clear_password(char ** /*error*/)
 {
     int ret = -1;
     unsigned int attempt, max_attempt, expire_sec;
@@ -383,6 +382,7 @@ int clear_password(char **error)
 
         return 0;
     }
+    return -1;
 }
 
 RUNNER_TEST_GROUP_INIT(SECURITY_SERVER_TESTS_SERVER);
@@ -634,7 +634,6 @@ RUNNER_TEST(tc04_check_API_passwd_denied)
     int ret = -1;
     unsigned int attempt, max_attempt, expire_sec;
     const char *subject_denied = TEST04_SUBJECT;
-    struct smack_accesses *handle = NULL;
     char *str = (char*) malloc(256);
 
     attempt = max_attempt = expire_sec = 0;
@@ -761,7 +760,6 @@ RUNNER_TEST(tc06_check_API_middleware_denied)
     char cookie[20];
     char *ss_label = NULL;
     char object[SECURITY_SERVER_MAX_OBJ_NAME];
-    struct smack_accesses *handle = NULL;
 
     ret = smack_set_label_for_self(subject_denied);
     RUNNER_ASSERT_MSG(ret == 0, "ret: " << ret);
@@ -822,7 +820,6 @@ RUNNER_CHILD_TEST(tc08_check_API_data_share_denied)
 {
     int ret = -1;
     const char *subject_denied = TEST08_SUBJECT;
-    struct smack_accesses *handle = NULL;
 
     ret = smack_set_label_for_self(subject_denied);
     RUNNER_ASSERT_MSG(ret == 0, "ret: " << ret);