videoaggregator: Fix string leak
authorSeungha Yang <seungha.yang@navercorp.com>
Fri, 15 Jun 2018 13:48:42 +0000 (22:48 +0900)
committerThibault Saunier <tsaunier@igalia.com>
Fri, 15 Jun 2018 14:17:14 +0000 (10:17 -0400)
gst_video_colorimetry_to_string() returns allocated memory which
must be freed.

https://bugzilla.gnome.org/show_bug.cgi?id=796596

gst-libs/gst/video/gstvideoaggregator.c

index 67de890..4e1fc26 100644 (file)
@@ -891,13 +891,14 @@ gst_video_aggregator_default_update_caps (GstVideoAggregator * vagg,
     gst_caps_unref (tmp);
   }
 
+  color_name = gst_video_colorimetry_to_string (&best_info.colorimetry);
+
   GST_DEBUG_OBJECT (vagg,
       "The output format will now be : %d with chroma : %s and colorimetry %s",
       best_format, gst_video_chroma_to_string (best_info.chroma_site),
-      gst_video_colorimetry_to_string (&best_info.colorimetry));
+      color_name);
 
   best_format_caps = gst_caps_copy (caps);
-  color_name = gst_video_colorimetry_to_string (&best_info.colorimetry);
   gst_caps_set_simple (best_format_caps, "format", G_TYPE_STRING,
       gst_video_format_to_string (best_format), "chroma-site", G_TYPE_STRING,
       gst_video_chroma_to_string (best_info.chroma_site), "colorimetry",