AMDGPU/GlobalISel: Remove hack for combines forming illegal extloads
authorMatt Arsenault <Matthew.Arsenault@amd.com>
Wed, 19 Aug 2020 17:59:11 +0000 (13:59 -0400)
committerMatt Arsenault <Matthew.Arsenault@amd.com>
Wed, 19 Aug 2020 18:15:38 +0000 (14:15 -0400)
Previously we weren't adding the LegalizerInfo to the post-legalizer
combiner. Since that's fixed, we don't need to try to filter out the
one case that was breaking.

llvm/lib/Target/AMDGPU/AMDGPUCombine.td

index faaf916..d243074 100644 (file)
@@ -47,18 +47,9 @@ def AMDGPUPreLegalizerCombinerHelper: GICombinerHelper<
   let DisableRuleOption = "amdgpuprelegalizercombiner-disable-rule";
 }
 
-
-// FIXME: combines_for_extload can introduce illegal extloads which
-// aren't re-legalized.
-// FIXME: Is there a way to remove a single item from all_combines?
-def all_combines_minus_extload : GICombineGroup<[trivial_combines,
-  ptr_add_immed_chain, combine_indexed_load_store, undef_combines,
-  identity_combines]
->;
-
 def AMDGPUPostLegalizerCombinerHelper: GICombinerHelper<
   "AMDGPUGenPostLegalizerCombinerHelper",
-  [all_combines_minus_extload, gfx6gfx7_combines,
+  [all_combines, gfx6gfx7_combines,
    uchar_to_float, cvt_f32_ubyteN]> {
   let DisableRuleOption = "amdgpupostlegalizercombiner-disable-rule";
 }