Fix static analysis issues 57/313657/1
authorHwankyu Jhun <h.jhun@samsung.com>
Mon, 1 Jul 2024 00:07:23 +0000 (09:07 +0900)
committerHwankyu Jhun <h.jhun@samsung.com>
Mon, 1 Jul 2024 00:07:23 +0000 (09:07 +0900)
Checker:
 - UNREACHABLE_CODE

Change-Id: I55e3bc5de380aeac81bf3220a12d5a4813a65a41
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
src/launchpad-process-pool/app_executor.cc
src/lib/launchpad/step_prepare_execution.cc

index b455bd6e7335f6bce73384ef909c523e37a40387..e08b293730f681310a9ccf5cd30e0a7a938dee0b 100644 (file)
@@ -207,12 +207,7 @@ int AppExecutor::StepMountResDir() {
     return ret;
   }
 
-  ret = Util::MountLibraryDirectories(app_info_->GetBundle());
-  if (ret != 0) {
-    _E("Failed to mount lib directories");
-    return ret;
-  }
-
+  Util::MountLibraryDirectories(app_info_->GetBundle());
   return Util::MountResourceDirectories(app_info_);
 }
 
index 0c177a62ba93248b9c0cd0f20c14074d769c6d79..c9262a9c423edbbcf7d576e0a2501a0f1e8bc262 100644 (file)
@@ -110,13 +110,7 @@ int StepPrepareExecution::MountResourceDirectories(AppInfo* app_info) {
     }
   }
 
-  int ret = Util::MountResourceDirectories(app_info);
-  if (ret < 0) {
-    _E("Failed to mount resource direstories. error: %d", ret);
-    return -1;
-  }
-
-  return 0;
+  return Util::MountResourceDirectories(app_info);
 }
 
 int StepPrepareExecution::SecurityManagerPrepareApp(AppInfo* app_info) {
@@ -192,13 +186,7 @@ int StepPrepareExecution::PrepareAppSocket(AppInfo* app_info) {
 }
 
 int StepPrepareExecution::PrepareIdFile(AppInfo* app_info) {
-  int ret = Util::PrepareAppIdFile(app_info);
-  if (ret < 0) {
-    _E("Failed to prepare id file. error: %d", ret);
-    return -1;
-  }
-
-  return 0;
+  return Util::PrepareAppIdFile(app_info);
 }
 
 int StepPrepareExecution::SendStartupSignal(AppInfo* app_info) {