scsi: core: use kobj_to_dev
authorGuosong Su <suguosong@xiaomi.com>
Tue, 25 Feb 2020 10:04:11 +0000 (18:04 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 29 Feb 2020 01:43:53 +0000 (20:43 -0500)
Use kobj_to_dev to instead of open-coding it.

Link: https://lore.kernel.org/r/20200225100411.10250-1-guosongsu@gmail.com
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Guosong Su <suguosong@xiaomi.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_sysfs.c

index 677b5c5..c3a30ba 100644 (file)
@@ -856,7 +856,7 @@ show_vpd_##_page(struct file *filp, struct kobject *kobj,   \
                 struct bin_attribute *bin_attr,                        \
                 char *buf, loff_t off, size_t count)                   \
 {                                                                      \
-       struct device *dev = container_of(kobj, struct device, kobj);   \
+       struct device *dev = kobj_to_dev(kobj);                         \
        struct scsi_device *sdev = to_scsi_device(dev);                 \
        struct scsi_vpd *vpd_page;                                      \
        int ret = -EINVAL;                                              \
@@ -884,7 +884,7 @@ static ssize_t show_inquiry(struct file *filep, struct kobject *kobj,
                            struct bin_attribute *bin_attr,
                            char *buf, loff_t off, size_t count)
 {
-       struct device *dev = container_of(kobj, struct device, kobj);
+       struct device *dev = kobj_to_dev(kobj);
        struct scsi_device *sdev = to_scsi_device(dev);
 
        if (!sdev->inquiry)
@@ -1181,7 +1181,7 @@ static DEVICE_ATTR(queue_ramp_up_period, S_IRUGO | S_IWUSR,
 static umode_t scsi_sdev_attr_is_visible(struct kobject *kobj,
                                         struct attribute *attr, int i)
 {
-       struct device *dev = container_of(kobj, struct device, kobj);
+       struct device *dev = kobj_to_dev(kobj);
        struct scsi_device *sdev = to_scsi_device(dev);
 
 
@@ -1207,7 +1207,7 @@ static umode_t scsi_sdev_attr_is_visible(struct kobject *kobj,
 static umode_t scsi_sdev_bin_attr_is_visible(struct kobject *kobj,
                                             struct bin_attribute *attr, int i)
 {
-       struct device *dev = container_of(kobj, struct device, kobj);
+       struct device *dev = kobj_to_dev(kobj);
        struct scsi_device *sdev = to_scsi_device(dev);