net/mlx5e: Don't block routes with nexthop objects in SW
authorMaor Dickman <maord@nvidia.com>
Thu, 30 Dec 2021 09:20:10 +0000 (11:20 +0200)
committerSaeed Mahameed <saeedm@nvidia.com>
Fri, 7 Jan 2022 00:55:40 +0000 (16:55 -0800)
Routes with nexthop objects is currently not supported by multipath offload
and any attempts to use it is blocked, however this also block adding SW
routes with nexthop.

Resolve this by returning NOTIFY_DONE instead of an error which will allow such
a route to be created in SW but not offloaded.

This fix also solve an issue which block adding such routes on different devices
due to missing check if the route FIB device is one of multipath devices.

Fixes: 6a87afc072c3 ("mlx5: Fail attempts to use routes with nexthop objects")
Signed-off-by: Maor Dickman <maord@nvidia.com>
Reviewed-by: Roi Dayan <roid@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/lag/mp.c

index bf4d3cbefa633ed9349125938381b8a5af2d581a..1ca01a5b6cdd803ed206685be19ddbcd12bcfe52 100644 (file)
@@ -268,10 +268,8 @@ static int mlx5_lag_fib_event(struct notifier_block *nb,
                fen_info = container_of(info, struct fib_entry_notifier_info,
                                        info);
                fi = fen_info->fi;
-               if (fi->nh) {
-                       NL_SET_ERR_MSG_MOD(info->extack, "IPv4 route with nexthop objects is not supported");
-                       return notifier_from_errno(-EINVAL);
-               }
+               if (fi->nh)
+                       return NOTIFY_DONE;
                fib_dev = fib_info_nh(fen_info->fi, 0)->fib_nh_dev;
                if (fib_dev != ldev->pf[MLX5_LAG_P1].netdev &&
                    fib_dev != ldev->pf[MLX5_LAG_P2].netdev) {