gst/playback/gstdecodebin.c: free plugin list correctly

Original commit message from CVS:
* gst/playback/gstdecodebin.c: free plugin list correctly
* gst/playback/gstplaybin.c: emit warning if autovideosink
and autoaudiosink can't be found (instead of segfaulting)

diff --git a/ChangeLog b/ChangeLog
index 5e50fd9..03420d8 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2005-09-18  David Schleef  <ds@schleef.org>
+
+       * gst/playback/gstdecodebin.c: free plugin list correctly
+       * gst/playback/gstplaybin.c: emit warning if autovideosink
+         and autoaudiosink can't be found (instead of segfaulting)
+
 2005-09-17  Thomas Vander Stichele  <thomas at apestaart dot org>
 
        * check/elements/audioconvert.c: (GST_START_TEST):

diff --git a/common b/common
index 39250a9..3f8b422 160000 (submodule)
--- a/common
+++ b/common
@@ -1 +1 @@
-Subproject commit 39250a956e1dfc010fe9f9d93ca1e2c3a343cdca
+Subproject commit 3f8b422d851dc64797cdd97dd7a2014acd751386

diff --git a/gst/playback/gstdecodebin.c b/gst/playback/gstdecodebin.c
index cc80114..c78d714 100644 (file)
--- a/gst/playback/gstdecodebin.c
+++ b/gst/playback/gstdecodebin.c
@@ -348,7 +348,7 @@ gst_decode_bin_dispose (GObject * object)
 
   decode_bin = GST_DECODE_BIN (object);
 
-  g_list_free (decode_bin->factories);
+  gst_plugin_feature_list_free (decode_bin->factories);
 
   G_OBJECT_CLASS (parent_class)->dispose (object);
 }

diff --git a/gst/playback/gstplaybin.c b/gst/playback/gstplaybin.c
index 4bd904a..4d438af 100644 (file)
--- a/gst/playback/gstplaybin.c
+++ b/gst/playback/gstplaybin.c
@@ -396,6 +396,9 @@ gen_video_element (GstPlayBin * play_bin)
     sink = play_bin->video_sink;
   } else {
     sink = gst_element_factory_make ("autovideosink", "videosink");
+    if (sink == NULL) {
+      g_warning ("could not create autovideosink element");
+    }
   }
   gst_object_ref (sink);
   g_hash_table_insert (play_bin->cache, "video_sink", sink);
@@ -510,6 +513,9 @@ gen_audio_element (GstPlayBin * play_bin)
     sink = play_bin->audio_sink;
   } else {
     sink = gst_element_factory_make ("autoaudiosink", "audiosink");
+    if (sink == NULL) {
+      g_warning ("could not create autoaudiosink element");
+    }
     play_bin->audio_sink = GST_ELEMENT (gst_object_ref (sink));
   }