xen/netback: don't call kfree_skb() under spin_lock_irqsave()
authorYang Yingliang <yangyingliang@huawei.com>
Mon, 5 Dec 2022 14:13:33 +0000 (22:13 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Wed, 7 Dec 2022 15:00:33 +0000 (16:00 +0100)
It is not allowed to call kfree_skb() from hardware interrupt
context or with interrupts being disabled. So replace kfree_skb()
with dev_kfree_skb_irq() under spin_lock_irqsave().

Fixes: be81992f9086 ("xen/netback: don't queue unlimited number of packages")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Paul Durrant <paul@xen.org>
Link: https://lore.kernel.org/r/20221205141333.3974565-1-yangyingliang@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/xen-netback/rx.c

index 9327621..d022206 100644 (file)
@@ -92,7 +92,7 @@ void xenvif_rx_queue_tail(struct xenvif_queue *queue, struct sk_buff *skb)
                struct net_device *dev = queue->vif->dev;
 
                netif_tx_stop_queue(netdev_get_tx_queue(dev, queue->id));
-               kfree_skb(skb);
+               dev_kfree_skb_irq(skb);
                queue->vif->dev->stats.rx_dropped++;
        } else {
                if (skb_queue_empty(&queue->rx_queue))