Modify svace issues - applying review comments

Signed-off-by: Hyerim Kim <rimi.kim@samsung.com>
Change-Id: If212e4dbdc1caaeaed2e88b9f95e529775e42bd9

diff --git a/src/util.c b/src/util.c
index 91f6bd7..1762e57 100755 (executable)
--- a/src/util.c
+++ b/src/util.c
@@ -130,15 +130,16 @@ Evas_Object *util_show_notification_popup(
        notification_get_text(noti, NOTIFICATION_TEXT_TYPE_TITLE, &title);
        notification_get_text(noti, NOTIFICATION_TEXT_TYPE_CONTENT, &temp_content);
 
-       content = (char *)calloc(strlen(start_tag)+strlen(temp_content)+strlen(end_tag), sizeof(char));
-       snprintf(content, strlen(start_tag)+strlen(temp_content)+strlen(end_tag), "%s%s%s", start_tag, temp_content, end_tag);
+       int buffer_size = strlen(start_tag)+strlen(temp_content)+strlen(end_tag);
+
+       content = (char *)calloc(buffer_size+1, sizeof(char));
+       snprintf(content, buffer_size, "%s%s%s", start_tag, temp_content, end_tag);
 
        /* Creating a Notification Window */
        notification_popup = elm_win_add(NULL, "notification_popup", ELM_WIN_BASIC);
 
        if (notification_popup == NULL) {
                _ERR("elm_win_add failed");
-               free(content);
                goto out;
        }
 
@@ -147,7 +148,6 @@ Evas_Object *util_show_notification_popup(
                _ERR("evas_object_evas_get failed");
                evas_object_del(notification_popup);
                notification_popup = NULL;
-               free(content);
                goto out;
        }
 
@@ -156,7 +156,6 @@ Evas_Object *util_show_notification_popup(
                _ERR("ecore_evas_ecore_evas_get failed");
                evas_object_del(notification_popup);
                notification_popup = NULL;
-               free(content);
                goto out;
        }
 
@@ -230,6 +229,9 @@ Evas_Object *util_show_notification_popup(
        elm_win_activate(notification_popup);
 
 out:
+       if(content != NULL)
+               free(content);
+
        return notification_popup;
 }