mtd: rawnand: brcmnand: Assign soc as early as possible
authorFlorian Fainelli <f.fainelli@gmail.com>
Fri, 7 Jan 2022 18:46:06 +0000 (10:46 -0800)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Sun, 23 Jan 2022 15:37:18 +0000 (16:37 +0100)
In order to key off the brcmnand_probe() code in subsequent changes
depending upon ctrl->soc, assign that variable as early as possible,
instead of much later when we have checked that it is non-NULL.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20220107184614.2670254-2-f.fainelli@gmail.com
drivers/mtd/nand/raw/brcmnand/brcmnand.c

index f759297..63080ae 100644 (file)
@@ -2998,6 +2998,7 @@ int brcmnand_probe(struct platform_device *pdev, struct brcmnand_soc *soc)
 
        dev_set_drvdata(dev, ctrl);
        ctrl->dev = dev;
+       ctrl->soc = soc;
 
        init_completion(&ctrl->done);
        init_completion(&ctrl->dma_done);
@@ -3138,8 +3139,6 @@ int brcmnand_probe(struct platform_device *pdev, struct brcmnand_soc *soc)
         * interesting ways
         */
        if (soc) {
-               ctrl->soc = soc;
-
                ret = devm_request_irq(dev, ctrl->irq, brcmnand_irq, 0,
                                       DRV_NAME, ctrl);