id3demux: fix parsing of unsynced frames with data length indicator

Fixes bug #614158.

diff --git a/gst/id3demux/id3v2frames.c b/gst/id3demux/id3v2frames.c
index 79fdf61b322baf3107ae1e07a6bad11ff648a7f5..021a3d173cb3051019717c32f7eed84297a610af 100644 (file)
--- a/gst/id3demux/id3v2frames.c
+++ b/gst/id3demux/id3v2frames.c
@@ -116,9 +116,11 @@ id3demux_id3v2_parse_frame (ID3TagsWorking * work)
     }
     frame_data += 4;
     frame_data_size -= 4;
-    if (work->parse_size < frame_data_size) {
-      GST_WARNING ("ID3v2 frame %s has invalid size %d.", tag_name,
-          frame_data_size);
+    GST_LOG ("Un-unsynced data size %d (of %d)", work->parse_size,
+        frame_data_size);
+    if (work->parse_size > frame_data_size) {
+      GST_WARNING ("ID3v2 frame %s data has invalid size %d (>%d)",
+          work->frame_id, work->parse_size, frame_data_size);
       return FALSE;
     }
   }