ASoC: SOF: Remove redundant return statements
authortangmeng <tangmeng@uniontech.com>
Wed, 30 Mar 2022 20:19:26 +0000 (13:19 -0700)
committerMark Brown <broonie@kernel.org>
Mon, 4 Apr 2022 07:39:11 +0000 (08:39 +0100)
After the free PCM action is executed, no matter what
the return result is, it will return directly in sof_pcm_trigger.
So the return statement here is redundant.

Signed-off-by: tangmeng <tangmeng@uniontech.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://lore.kernel.org/r/20220330201926.1330402-12-ranjani.sridharan@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/pcm.c

index 658cd89..b5cbc8b 100644 (file)
@@ -347,12 +347,9 @@ static int sof_pcm_trigger(struct snd_soc_component *component,
                snd_sof_pcm_platform_trigger(sdev, substream, cmd);
 
        /* free PCM if reset_hw_params is set and the STOP IPC is successful */
-       if (!ret && reset_hw_params) {
+       if (!ret && reset_hw_params)
                ret = sof_pcm_stream_free(sdev, substream, spcm, substream->stream,
                                          free_widget_list);
-               if (ret < 0)
-                       return ret;
-       }
 
        return ret;
 }