iommu/vt-d: Don't dereference iommu_device if IOMMU_API is not built
authorBartosz Golaszewski <bgolaszewski@baylibre.com>
Tue, 13 Oct 2020 07:30:55 +0000 (09:30 +0200)
committerJoerg Roedel <jroedel@suse.de>
Mon, 19 Oct 2020 12:16:02 +0000 (14:16 +0200)
Since commit c40aaaac1018 ("iommu/vt-d: Gracefully handle DMAR units
with no supported address widths") dmar.c needs struct iommu_device to
be selected. We can drop this dependency by not dereferencing struct
iommu_device if IOMMU_API is not selected and by reusing the information
stored in iommu->drhd->ignored instead.

This fixes the following build error when IOMMU_API is not selected:

drivers/iommu/intel/dmar.c: In function ‘free_iommu’:
drivers/iommu/intel/dmar.c:1139:41: error: ‘struct iommu_device’ has no member named ‘ops’
 1139 |  if (intel_iommu_enabled && iommu->iommu.ops) {
                                                ^

Fixes: c40aaaac1018 ("iommu/vt-d: Gracefully handle DMAR units with no supported address widths")
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Acked-by: Lu Baolu <baolu.lu@linux.intel.com>
Acked-by: David Woodhouse <dwmw@amazon.co.uk>
Link: https://lore.kernel.org/r/20201013073055.11262-1-brgl@bgdev.pl
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/intel/dmar.c

index 54d790f75824779b3abf6d84398d29afd8b06e80..f0b614122446fb433df43997e41bdfa6234f0b26 100644 (file)
@@ -1133,7 +1133,7 @@ error:
 
 static void free_iommu(struct intel_iommu *iommu)
 {
-       if (intel_iommu_enabled && iommu->iommu.ops) {
+       if (intel_iommu_enabled && !iommu->drhd->ignored) {
                iommu_device_unregister(&iommu->iommu);
                iommu_device_sysfs_remove(&iommu->iommu);
        }