fuse: fix writepages on 32bit
authorMiklos Szeredi <mszeredi@redhat.com>
Wed, 24 Apr 2019 15:05:06 +0000 (17:05 +0200)
committerMiklos Szeredi <mszeredi@redhat.com>
Wed, 24 Apr 2019 15:05:06 +0000 (17:05 +0200)
Writepage requests were cropped to i_size & 0xffffffff, which meant that
mmaped writes to any file larger than 4G might be silently discarded.

Fix by storing the file size in a properly sized variable (loff_t instead
of size_t).

Reported-by: Antonio SJ Musumeci <trapexit@spawn.link>
Fixes: 6eaf4782eb09 ("fuse: writepages: crop secondary requests")
Cc: <stable@vger.kernel.org> # v3.13
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
fs/fuse/file.c

index 06096b6..5428c81 100644 (file)
@@ -1586,7 +1586,7 @@ __acquires(fi->lock)
 {
        struct fuse_conn *fc = get_fuse_conn(inode);
        struct fuse_inode *fi = get_fuse_inode(inode);
-       size_t crop = i_size_read(inode);
+       loff_t crop = i_size_read(inode);
        struct fuse_req *req;
 
        while (fi->writectr >= 0 && !list_empty(&fi->queued_writes)) {