Fix coding style

Change-Id: I77493692e72af5b2d4af5ca1113ef3f04f608de5
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>

diff --git a/src/ac-internal.cc b/src/ac-internal.cc
index a0b5e7a..3f3af65 100644 (file)
--- a/src/ac-internal.cc
+++ b/src/ac-internal.cc
@@ -20,6 +20,8 @@
 #include <dlog.h>
 #include <pkgmgr-info.h>
 
+#include <utility>
+
 #include "ac-internal.hh"
 #include "aul-internal.hh"
 #include "log-private.hh"

diff --git a/src/client-socket-internal.hh b/src/client-socket-internal.hh
index de7e960..2446e38 100644 (file)
--- a/src/client-socket-internal.hh
+++ b/src/client-socket-internal.hh
@@ -25,7 +25,7 @@ namespace internal {
 class ClientSocket {
  public:
   ClientSocket();
-  ClientSocket(int fd);
+  explicit ClientSocket(int fd);
   virtual ~ClientSocket();
 
   void Close();

diff --git a/src/debug-port-internal.cc b/src/debug-port-internal.cc
index 8b28c77..ab660a3 100644 (file)
--- a/src/debug-port-internal.cc
+++ b/src/debug-port-internal.cc
@@ -20,6 +20,8 @@
 #include <sys/un.h>
 #include <time.h>
 
+#include <utility>
+
 #include "debug-port-internal.hh"
 #include "log-private.hh"
 

diff --git a/src/debug-port-internal.hh b/src/debug-port-internal.hh
index 98a3042..ac63f41 100644 (file)
--- a/src/debug-port-internal.hh
+++ b/src/debug-port-internal.hh
@@ -27,6 +27,7 @@
 #include <mutex>
 #include <string>
 #include <thread>
+#include <utility>
 
 #include "port-internal.hh"
 #include "shared-queue-internal.hh"

diff --git a/src/exception-internal.cc b/src/exception-internal.cc
index 0ee27f0..8e21f20 100644 (file)
--- a/src/exception-internal.cc
+++ b/src/exception-internal.cc
@@ -16,6 +16,8 @@
 
 #include "exception-internal.hh"
 
+#include <utility>
+
 namespace rpc_port {
 namespace internal {
 

diff --git a/src/port-internal.cc b/src/port-internal.cc
index 79438f2..9ae6802 100644 (file)
--- a/src/port-internal.cc
+++ b/src/port-internal.cc
@@ -24,6 +24,8 @@
 #include <unistd.h>
 #include <uuid/uuid.h>
 
+#include <utility>
+
 #include "include/rpc-port.h"
 #include "log-private.hh"
 #include "port-internal.hh"
@@ -268,7 +270,7 @@ gboolean Port::OnEventReceived(gint fd, GIOCondition cond,
 void Port::ClearQueue() {
   std::lock_guard<std::recursive_mutex> lock(mutex_);
 
-  while(queue_.empty() == false)
+  while (queue_.empty() == false)
     queue_.pop();
 
   if (delay_src_id_ != 0) {

diff --git a/src/port-internal.hh b/src/port-internal.hh
index d6fc428..bda4d41 100644 (file)
--- a/src/port-internal.hh
+++ b/src/port-internal.hh
@@ -84,9 +84,9 @@ class Port {
   };
 
   enum PortStatus {
-   PORT_STATUS_ERROR_NONE,
-   PORT_STATUS_ERROR_IO_ERROR,
-   PORT_STATUS_ERROR_RESOURCE_UNAVAILABLE
+    PORT_STATUS_ERROR_NONE,
+    PORT_STATUS_ERROR_IO_ERROR,
+    PORT_STATUS_ERROR_RESOURCE_UNAVAILABLE
   };
 
   int PushDelayedMessage(std::shared_ptr<DelayMessage> dm);

diff --git a/src/proxy-internal.cc b/src/proxy-internal.cc
index f22c6ca..35abc75 100644 (file)
--- a/src/proxy-internal.cc
+++ b/src/proxy-internal.cc
@@ -21,6 +21,8 @@
 #include <uuid.h>
 
 #include <memory>
+#include <utility>
+#include <vector>
 
 #include "aul-internal.hh"
 #include "debug-port-internal.hh"

diff --git a/src/proxy-internal.hh b/src/proxy-internal.hh
index 414888f..5003539 100644 (file)
--- a/src/proxy-internal.hh
+++ b/src/proxy-internal.hh
@@ -87,7 +87,7 @@ class Proxy : public std::enable_shared_from_this<Proxy> {
 
   class Client : public ClientSocket {
    public:
-    Client(Proxy* parent);
+    explicit Client(Proxy* parent);
     virtual ~Client();
 
     static Client* Create(Proxy* parent, const std::string& endpoint);

diff --git a/src/request-internal.cc b/src/request-internal.cc
index ef15ad5..af78026 100644 (file)
--- a/src/request-internal.cc
+++ b/src/request-internal.cc
@@ -16,6 +16,8 @@
 
 #include "request-internal.hh"
 
+#include <utility>
+
 namespace rpc_port {
 namespace internal {
 

diff --git a/src/response-internal.hh b/src/response-internal.hh
index 4855b81..25227d3 100644 (file)
--- a/src/response-internal.hh
+++ b/src/response-internal.hh
@@ -25,7 +25,7 @@ namespace internal {
 
 class Response : public tizen_base::Parcelable {
  public:
-  Response(int result);
+  explicit Response(int result);
   Response();
   ~Response();
 

diff --git a/src/rpc-port.cc b/src/rpc-port.cc
index 1410a04..310cfbc 100644 (file)
--- a/src/rpc-port.cc
+++ b/src/rpc-port.cc
@@ -21,6 +21,7 @@
 #include <atomic>
 #include <mutex>
 #include <thread>
+#include <utility>
 
 #include "include/rpc-port-internal.h"
 #include "include/rpc-port.h"
@@ -47,7 +48,7 @@ class Event {
 
 class ProxyExt : public Proxy, public Proxy::IEventListener {
  public:
-  explicit ProxyExt() : Proxy(), destroying_(false) {}
+  ProxyExt() : Proxy(), destroying_(false) {}
   virtual ~ProxyExt() = default;
 
   void AddConnectedEventListener(rpc_port_proxy_connected_event_cb cb,

diff --git a/src/server-socket-internal.hh b/src/server-socket-internal.hh
index ae025ac..47ca970 100644 (file)
--- a/src/server-socket-internal.hh
+++ b/src/server-socket-internal.hh
@@ -24,7 +24,7 @@ namespace internal {
 
 class ServerSocket {
  public:
-  ServerSocket(int fd);
+  explicit ServerSocket(int fd);
   virtual ~ServerSocket();
 
   bool IsClosed();

diff --git a/src/stub-internal.cc b/src/stub-internal.cc
index 63cea83..553a9a6 100644 (file)
--- a/src/stub-internal.cc
+++ b/src/stub-internal.cc
@@ -20,6 +20,9 @@
 #include <sys/socket.h>
 #include <sys/types.h>
 
+#include <utility>
+#include <vector>
+
 #include "aul-internal.hh"
 #include "debug-port-internal.hh"
 #include "include/rpc-port.h"
@@ -222,7 +225,7 @@ gboolean Stub::OnSocketDisconnected(GIOChannel* channel, GIOCondition cond,
     }
   }
 
-  return G_SOURCE_REMOVE;;
+  return G_SOURCE_REMOVE;
 }
 
 void Stub::AddAcceptedPort(const std::string& sender_appid,

diff --git a/utils/debug-port.cc b/utils/debug-port.cc
index 7a5229b..202d9da 100644 (file)
--- a/utils/debug-port.cc
+++ b/utils/debug-port.cc
@@ -22,6 +22,7 @@
 #include <sys/un.h>
 
 #include <iostream>
+#include <utility>
 #include <vector>
 
 #include "debug-port.hh"

diff --git a/utils/logger.cc b/utils/logger.cc
index 7bb1895..8d1608f 100644 (file)
--- a/utils/logger.cc
+++ b/utils/logger.cc
@@ -87,8 +87,7 @@ int Logger::Read(void* buf, unsigned int size) {
   return 0;
 }
 
-rpc_port_parcel_h Logger::Read()
-{
+rpc_port_parcel_h Logger::Read() {
   int size = 0;
   int ret = Read(reinterpret_cast<void*>(&size), sizeof(size));
   if (ret < 0 || size <= 0)

diff --git a/utils/message.cc b/utils/message.cc
index 17fa647..47be341 100644 (file)
--- a/utils/message.cc
+++ b/utils/message.cc
@@ -20,6 +20,7 @@
 #include <ctime>
 #include <iostream>
 #include <iomanip>
+#include <utility>
 
 #include "message.hh"