drm/amd/pm: use kmemdup() rather than kmalloc+memcpy
authorAlex Dewar <alex.dewar90@gmail.com>
Mon, 24 Aug 2020 21:15:25 +0000 (22:15 +0100)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 26 Aug 2020 20:40:19 +0000 (16:40 -0400)
Issue identified with Coccinelle.

Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_processpptables.c

index f56a3cb..1f90825 100644 (file)
@@ -890,14 +890,12 @@ static int init_powerplay_table_information(
                                power_saving_clock_count);
        }
 
-       pptable_information->smc_pptable = kmalloc(sizeof(PPTable_t), GFP_KERNEL);
+       pptable_information->smc_pptable = kmemdup(&(powerplay_table->smcPPTable),
+                                                  sizeof(PPTable_t),
+                                                  GFP_KERNEL);
        if (pptable_information->smc_pptable == NULL)
                return -ENOMEM;
 
-       memcpy(pptable_information->smc_pptable,
-                       &(powerplay_table->smcPPTable),
-                       sizeof(PPTable_t));
-
 
        result = append_vbios_pptable(hwmgr, (pptable_information->smc_pptable));
        if (result)