ACPI: fan: Fix error reporting to user space

When user get/set cur_state fails, it should be some negative error
value instead of whatever returned by acpi_evaluate_object() or from
acpi_execute_simple_method(). The return value from these apis is
some positive values greater than 0. For example if AE_NOT_FOUND
is returned it will be "5".

In other ACPI drivers, -ENODEV is returned when ACPI_FAILURE(status)
is true. Do the same thing here for thermal sysfs callbacks for
get and set for failures.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c
index 5cd0ceb..098d645 100644 (file)
--- a/drivers/acpi/fan.c
+++ b/drivers/acpi/fan.c
@@ -107,7 +107,7 @@ static int fan_get_state_acpi4(struct acpi_device *device, unsigned long *state)
        status = acpi_evaluate_object(device->handle, "_FST", NULL, &buffer);
        if (ACPI_FAILURE(status)) {
                dev_err(&device->dev, "Get fan state failed\n");
-               return status;
+               return -ENODEV;
        }
 
        obj = buffer.pointer;
@@ -195,7 +195,7 @@ static int fan_set_state_acpi4(struct acpi_device *device, unsigned long state)
                                            fan->fps[state].control);
        if (ACPI_FAILURE(status)) {
                dev_dbg(&device->dev, "Failed to set state by _FSL\n");
-               return status;
+               return -ENODEV;
        }
 
        return 0;