perf/core: Call LSM hook after copying perf_event_attr

commit 0a041ebca4956292cadfb14a63ace3a9c1dcb0a3 upstream.

It passes the attr struct to the security_perf_event_open() but it's
not initialized yet.

Fixes: da97e18458fb ("perf_event: Add support for LSM and SELinux checks")
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/20221220223140.4020470-1-namhyung@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 732b392..3b9e861 100644 (file)
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -12231,12 +12231,12 @@ SYSCALL_DEFINE5(perf_event_open,
        if (flags & ~PERF_FLAG_ALL)
                return -EINVAL;
 
-       /* Do we allow access to perf_event_open(2) ? */
-       err = security_perf_event_open(&attr, PERF_SECURITY_OPEN);
+       err = perf_copy_attr(attr_uptr, &attr);
        if (err)
                return err;
 
-       err = perf_copy_attr(attr_uptr, &attr);
+       /* Do we allow access to perf_event_open(2) ? */
+       err = security_perf_event_open(&attr, PERF_SECURITY_OPEN);
        if (err)
                return err;