btrfs-progs: don't leak fd in test_dev_for_mkfs() error paths
authorEric Sandeen <sandeen@redhat.com>
Wed, 6 Nov 2013 23:15:44 +0000 (17:15 -0600)
committerChris Mason <chris.mason@fusionio.com>
Thu, 7 Nov 2013 21:10:41 +0000 (16:10 -0500)
Close fd before we return on error paths.

Resolves-Coverity-CID: 1125939
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: Chris Mason <chris.mason@fusionio.com>
utils.c

diff --git a/utils.c b/utils.c
index 47ba23b..9af49f7 100644 (file)
--- a/utils.c
+++ b/utils.c
@@ -1928,10 +1928,12 @@ int test_dev_for_mkfs(char *file, int force_overwrite, char *estr)
        if (fstat(fd, &st)) {
                snprintf(estr, sz, "unable to stat %s: %s\n", file,
                        strerror(errno));
+               close(fd);
                return 1;
        }
        if (!S_ISBLK(st.st_mode)) {
                fprintf(stderr, "'%s' is not a block device\n", file);
+               close(fd);
                return 1;
        }
        close(fd);