evas: deprecate evas_device_parent_set.

Summary:
It is unlikely that the code was working before and it was a bad idea
anyway. There is no user of this API in EFL.

Depends on D10490

Reviewers: zmike, raster, bu5hm4n, Hermet

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8321

Differential Revision: https://phab.enlightenment.org/D10491

diff --git a/src/lib/evas/Evas_Common.h b/src/lib/evas/Evas_Common.h
index 3bede59..9d36ad4 100644 (file)
--- a/src/lib/evas/Evas_Common.h
+++ b/src/lib/evas/Evas_Common.h
@@ -1167,7 +1167,7 @@ EAPI const char *evas_device_description_get(const Evas_Device *dev);
  *
  * @since 1.8
  */
-EAPI void evas_device_parent_set(Evas_Device *dev, Evas_Device *parent);
+EAPI void evas_device_parent_set(Evas_Device *dev, Evas_Device *parent) EINA_DEPRECATED;
 
 /**
  * Get the parent of a device

diff --git a/src/lib/evas/canvas/evas_device.c b/src/lib/evas/canvas/evas_device.c
index d0a68bd..c836931 100644 (file)
--- a/src/lib/evas/canvas/evas_device.c
+++ b/src/lib/evas/canvas/evas_device.c
@@ -335,25 +335,12 @@ evas_device_description_get(const Evas_Device *dev)
 }
 
 EAPI void
-evas_device_parent_set(Evas_Device *dev, Evas_Device *parent)
+evas_device_parent_set(Evas_Device *dev EINA_UNUSED, Evas_Device *parent EINA_UNUSED)
 {
    // Note: This function should be deprecated. parent_set doesn't make sense
    // unless the parent is a seat device. Parent shouldn't be changed after
    // creation.
-
-   SAFETY_CHECK(dev, EFL_INPUT_DEVICE_CLASS);
-
-   if (parent)
-     {
-        SAFETY_CHECK(parent, EFL_INPUT_DEVICE_CLASS);
-     }
-   else if (efl_parent_get(dev))
-     {
-        efl_ref(dev);
-     }
-
-   efl_parent_set(dev, parent);
-   evas_event_callback_call(efl_input_device_evas_get(dev), EVAS_CALLBACK_DEVICE_CHANGED, dev);
+   ERR("It is not advised and possible anymore to changed the parent of an Evas_Device.");
 }
 
 EAPI const Evas_Device *