lib: utils/fdt: simplify dt_parse_isa_extensions

hart_exts == NULL can only occur if offset and node address lead to an
overflow resulting in exactly NULL. As we don't catch other values of
overflow it does not make sense to treat this one as special.

Addresses-Coverity-ID: 1568355 Logically dead code
Addresses-Coverity-ID: 1568358 Logically dead code
Fixes: 6259b2ec2d09 ("lib: utils/fdt: Fix fdt_parse_isa_extensions() implementation")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Xiang W <wxjstz@126.com>
Reviewed-by: Anup Patel <anup@brainfault.org>

diff --git a/lib/utils/fdt/fdt_helper.c b/lib/utils/fdt/fdt_helper.c
index c97f09d3cc3b9a7f1e72601005f415b781e711a2..13e79b96f7e90a01be526834546fab8d1045fa58 100644 (file)
--- a/lib/utils/fdt/fdt_helper.c
+++ b/lib/utils/fdt/fdt_helper.c
@@ -417,8 +417,6 @@ static int fdt_parse_isa_all_harts(void *fdt)
 
                hart_exts = sbi_scratch_offset_ptr(scratch,
                                                   fdt_isa_bitmap_offset);
-               if (!hart_exts)
-                       return SBI_ENOENT;
 
                err = fdt_parse_isa_one_hart((const char *)val, hart_exts);
                if (err)
@@ -452,8 +450,6 @@ int fdt_parse_isa_extensions(void *fdt, unsigned int hartid,
                return SBI_ENOENT;
 
        hart_exts = sbi_scratch_offset_ptr(scratch, fdt_isa_bitmap_offset);
-       if (!hart_exts)
-               return SBI_ENOENT;
 
        for (i = 0; i < BITS_TO_LONGS(SBI_HART_EXT_MAX); i++)
                extensions[i] |= hart_exts[i];