iio: adc: xilinx: use helper variable for &pdev->dev
authorBartosz Golaszewski <bgolaszewski@baylibre.com>
Mon, 30 Nov 2020 14:27:57 +0000 (15:27 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 9 Jan 2021 14:25:25 +0000 (14:25 +0000)
It's more elegant to use a helper local variable to store the address
of the underlying struct device than to dereference pdev everywhere.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Tested-by: Anand Ashok Dumbre <anandash@xilinx.com>
Reviewed-by: Anand Ashok Dumbre <anandash@xilinx.com>
Link: https://lore.kernel.org/r/20201130142759.28216-2-brgl@bgdev.pl
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/xilinx-xadc-core.c

index 6fc2eaa..6e9145c 100644 (file)
@@ -1287,6 +1287,7 @@ static const char * const xadc_type_names[] = {
 
 static int xadc_probe(struct platform_device *pdev)
 {
+       struct device *dev = &pdev->dev;
        const struct of_device_id *id;
        struct iio_dev *indio_dev;
        unsigned int bipolar_mask;
@@ -1296,10 +1297,10 @@ static int xadc_probe(struct platform_device *pdev)
        int irq;
        int i;
 
-       if (!pdev->dev.of_node)
+       if (!dev->of_node)
                return -ENODEV;
 
-       id = of_match_node(xadc_of_match_table, pdev->dev.of_node);
+       id = of_match_node(xadc_of_match_table, dev->of_node);
        if (!id)
                return -EINVAL;
 
@@ -1307,7 +1308,7 @@ static int xadc_probe(struct platform_device *pdev)
        if (irq <= 0)
                return -ENXIO;
 
-       indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*xadc));
+       indio_dev = devm_iio_device_alloc(dev, sizeof(*xadc));
        if (!indio_dev)
                return -ENOMEM;
 
@@ -1327,7 +1328,7 @@ static int xadc_probe(struct platform_device *pdev)
        indio_dev->modes = INDIO_DIRECT_MODE;
        indio_dev->info = &xadc_info;
 
-       ret = xadc_parse_dt(indio_dev, pdev->dev.of_node, &conf0);
+       ret = xadc_parse_dt(indio_dev, dev->of_node, &conf0);
        if (ret)
                return ret;
 
@@ -1351,7 +1352,7 @@ static int xadc_probe(struct platform_device *pdev)
                }
        }
 
-       xadc->clk = devm_clk_get(&pdev->dev, NULL);
+       xadc->clk = devm_clk_get(dev, NULL);
        if (IS_ERR(xadc->clk)) {
                ret = PTR_ERR(xadc->clk);
                goto err_free_samplerate_trigger;
@@ -1377,7 +1378,7 @@ static int xadc_probe(struct platform_device *pdev)
        }
 
        ret = request_irq(xadc->irq, xadc->ops->interrupt_handler, 0,
-                       dev_name(&pdev->dev), indio_dev);
+                         dev_name(dev), indio_dev);
        if (ret)
                goto err_clk_disable_unprepare;